manual changes are lost when importing/exporting theme

[czuck]

I created a theme and downloaded it, then I opened the css file and made some changes to things I couldn't though the interface (such as a:visited). Then I uploaded the theme back into ThemeRoller so I could use the interface to make additional changes. When I downloaded it again, the manual changes I had made were lost.

[gabrielschulhof]

In order to identify the spot where the problem occurs, I need a copy of the theme that does not include your manual changes, as well as a copy of the theme that does include your manual changes. Can you please post the two tarballs somewhere and drop a link here?

[czuck]

From: gabrielschulhof [mailto:notifications@github.com]
Sent: Friday, September 12, 2014 1:19 PM
To: jquery/themeroller.jquerymobile.com
Cc: Blanda, Christine
Subject: Re: [themeroller.jquerymobile.com] manual changes are lost when importing/exporting theme (#208)

In order to identify the spot where the problem occurs, I need a copy of the theme that does not include your manual changes, as well as a copy of the theme that does include your manual changes. Can you please post the two tarballs somewhere and drop a link here?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/208#issuecomment-55434072.

[username1290]

Don't edit the themeroller file.
Suggestion: Add an "overrides.css" after "themeroller.css"
That way you'll have an untouched(clean) themeroller file, and more easily track all your changes in another one.

[agcolom]

I've just checked and was able to create a theme, download it, manually made changed (to a:hover and button hover colors), and reimported into the interface without any issue and the manual changes were present in the interface. I'm going to close this issue as I am not able to reproduce and we didn't receive details of what was not working.
@ceblanda If this is still an issue for you, please give us all the details of what manual changes are not imported into the interface, and I will re-open the issue.

[czuck]

When I tested, if I added additional items they were lost when imported and exported.
--C

From: Anne-Gaelle Colom [mailto:notifications@github.com]
Sent: Monday, November 23, 2015 4:53 PM
To: jquery/themeroller.jquerymobile.com themeroller.jquerymobile.com@noreply.github.com
Cc: Blanda, Christine Christine.Blanda@Jenzabar.com
Subject: Re: [themeroller.jquerymobile.com] manual changes are lost when importing/exporting theme (#208)

I've just checked and was able to create a theme, download it, manually made changed (to a:hover and button hover colors), and reimported into the interface without any issue and the manual changes were present in the interface. I'm going to close this issue as I am not able to reproduce and we didn't receive details of what was not working.
@ceblandahttps://github.com/ceblanda If this is still an issue for you, please give us all the details of what manual changes are not imported into the interface, and I will re-open the issue.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/208#issuecomment-159077019.

[agcolom]

@ceblanda thanks very much for your reply. I am not sure themeroller should take manual additions (as opposed to manual editions of provided values), as I believe additions should go into a separate css file added after the themeroller css, as suggested by @sogen.
@arschmitz @gabrielschulhof @jaspermdegroot could you please confirm whether this is the case, thank you.

[czuck]

Unfortunately that will not work in my situation.
--C

From: Anne-Gaelle Colom [mailto:notifications@github.com]
Sent: Monday, November 23, 2015 5:08 PM
To: jquery/themeroller.jquerymobile.com themeroller.jquerymobile.com@noreply.github.com
Cc: Blanda, Christine Christine.Blanda@Jenzabar.com
Subject: Re: [themeroller.jquerymobile.com] manual changes are lost when importing/exporting theme (#208)

@ceblandahttps://github.com/ceblanda thanks very much for your reply. I am not sure themeroller should take manual additions (as opposed to manual editions of provided values), as I believe additions should go into a separate css file added after the themeroller css, as suggested by @sogenhttps://github.com/sogen.
@arschmitzhttps://github.com/arschmitz @gabrielschulhofhttps://github.com/gabrielschulhof @jaspermdegroothttps://github.com/jaspermdegroot could you please confirm whether this is the case, thank you.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/208#issuecomment-159081763.

[jaspermdegroot]

Making changes in the CSS file shouldn't be a problem as long as all the property/value pairs where the value has a comment in it (/*{name-of-the-setting}*/}) stay.

[agcolom]

I've tried by adding .myclass { background-color: rgb(255,0,0) /*{this is for testing purposes}*/;} in various places but this was lost in the process. So is this a bug? (reopening the issue until we know for sure).

[jaspermdegroot]

And without the /*{this is for testing purposes}*/, is the custom rule removed?
That /*{ ... }*/ specific comment format shouldn't be used in anything that you add to the file. What I meant was that the original lines that have a comment of that format in it shouldn't be removed.

[agcolom]

@jaspermdegroot yes, in both cases (with comments and without comments) the addition is lost