Fix reason syntax #60
Conversation
The change was incorrect and due to the change, the highlighting didn't work anymore. We cannot match within a multiline string because it needs to match an "extension point" everything that happens inside that extension point is basically taken care of by the language extension. I also removed the extra items in contains, I am not sure why that needs to be there because it contains no reason at all, just GraphQL syntax. Also, the current change is independent of the reason-syntax you use.
|
@jfrolich could you also update the ReasonML tests for this change? I don't know much ReasonML, but I thought that the string containing GraphQL syntax within the extension point still allowed interpolation and other string template features. Do I have that wrong? |
Nope the raw contents are run through a pre-compilation step. I tried to fix it. But this line is still failing: I don't know where it got |
Got it.
That assertion can be removed. It's from the I have a better handle on what's required to make this work as you intended now and can take it from here. I'll try to get this fixed up later today. |
- Be more lenient with whitespace matches (more still to do) - Remove the vim-reasonml-specific syntax check - Remove the unnecessary 'filetype' setting
|
👍 Thanks so much! |
2 participants
The change was incorrect and due to the change, the highlighting didn't work anymore. We cannot match within a multiline string because it needs to match an "extension point" everything that happens inside that extension point is basically taken care of by the language extension. I also removed the extra items in contains, I am not sure why that needs to be there because it contains no reason at all, just GraphQL syntax. Also, the current change is independent of the reason-syntax you use.