Match JavaScript functions using dedicated regions #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our previous function-matching approach (#109) was implemented on top of the existing tag-matching patterns. This had the downside of including the function name and initial parenthesis in the region match. Instead, use dedicated syntax regions to specifically match the string template argument passed to our named GraphQL-aware functions for both JavaScript and TypeScript.
jparise
force-pushed
the
function-regions
branch
from
b3dfc23 to
266dc2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our previous function-matching approach (#109) was implemented on top of
the existing tag-matching patterns. This had the downside of including
the function name and initial parenthesis in the region match.
Instead, use dedicated syntax regions to specifically match the string
template argument passed to our named GraphQL-aware functions for both
JavaScript and TypeScript.