Skip to content

Conversation

@ehealy
Copy link
Contributor

@ehealy ehealy commented Oct 30, 2025

…tall-metadata file.

Exported bash functions take the format of BASH_FUNC_function_name%%. Including them in the .install-metadata file causes export errors, so update the filtering logic to account for them.

@jordansissel
Copy link
Owner

Code looks ok! I haven't tested, but researching what bash does to export functions shows that this PR looks right.

I tried to find a way to have bash simply unexport all functions, but getting a list of just the exported function names seems difficult to do more easily than you have shown, and as it fits with the existing grep pipeline, this seems ok:)

For posterity, best I could come up with was this one, to unexport any exported functions:

typeset -f +x $(typeset -xfp | sed -ne 's/^declare -fx //p')

@jordansissel jordansissel merged commit d9be498 into jordansissel:main Nov 14, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants