Skip to content

Add removal of LegacyPropertyManagementTrait from MVC #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jun 23, 2025

User description

This is the documentation PR for joomla/joomla-cms#44907


PR Type

Documentation


Description

  • Document removal of LegacyPropertyManagementTrait from MVC classes

  • Add migration guide for deprecated set() and get() methods

  • Provide code examples for property access changes


Changes walkthrough 📝

Relevant files
Documentation
removed-backward-incompatibility.md
Document MVC trait removal migration                                         

migrations/54-60/removed-backward-incompatibility.md

  • Add new section documenting LegacyPropertyManagementTrait removal
  • Include migration examples from generic methods to direct property
    access
  • Reference related PR #44907 for implementation details
  • +15/-0   

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Incomplete Migration

    The migration guide doesn't address potential null property access issues when migrating from get() with default values to direct property access with null coalescing operator. Consider adding guidance for handling undefined properties.

    ```php
    // Old:
    $this->set('key', 'value');
    $var = $this->get('key', 'defaultValue');
    
    // New:
    $this->key = 'value';
    $var = $this->key ?? 'defaultValue';
    
    </details>
    
    </td></tr>
    </table>
    

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant