Skip to content

Conversation

@jonasbb
Copy link
Owner

@jonasbb jonasbb commented Nov 27, 2025

The schema should be identical to BTreeSet.
Add schema implementations for other set types like HashSet and
IndexSet.
Add tests for SetLastValueWins, SetPreventDuplicates, MapFirstKeyWins,
MapPreventDuplicates, and JsonString.

Closes #906

The schema should be identical to BTreeSet.
Add schema implementations for other set types like HashSet and
IndexSet.
Add tests for SetLastValueWins, SetPreventDuplicates, MapFirstKeyWins,
MapPreventDuplicates, and JsonString.
@jonasbb jonasbb force-pushed the fix-schema-set-duplicates-906 branch from 6425941 to 0650180 Compare November 27, 2025 21:58
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 91.37931% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.11%. Comparing base (066b9d4) to head (0650180).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
serde_with/src/schemars_1.rs 73.68% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
+ Coverage   67.80%   68.11%   +0.30%     
==========================================
  Files          36       36              
  Lines        9537     9537              
==========================================
+ Hits         6467     6496      +29     
+ Misses       3070     3041      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonasbb jonasbb merged commit 1e54f1c into master Nov 27, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: JsonSchemaAs for SetPreventDuplicates<DisplayFromStr> schema is "string" not "array" of "string"

2 participants