Better handle serde_as on enum variants #499 #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the serde_as macro to warn on serde_as attributes on enum variant fields. They are unsupported (in contrast to serde_derive), so showing an error is better and avoids confusion when migrating. Also update the main examples to include an enum.
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
- Coverage 70.81% 70.59% -0.22%
==========================================
Files 52 52
Lines 3625 3636 +11
==========================================
Hits 2567 2567
- Misses 1058 1069 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Owner
Author
|
bors r+ |
Contributor
|
Build succeeded: |
ghedo
added a commit
to cloudflare/quiche
that referenced
this pull request
Feb 20, 2025
This bumps url to match the versions specified in the workspace. It also appears that the `serde_with` dependency was entirely unnecessary, as the `serde_as` use in the code never actually worked properly and it triggers a warning with newer versions (jonasbb/serde_with#502) so I just removed it.
ghedo
added a commit
to cloudflare/quiche
that referenced
this pull request
Feb 20, 2025
This bumps url to match the versions specified in the workspace. It also appears that the `serde_with` dependency was entirely unnecessary, as the `serde_as` use in the code never actually worked properly and it triggers a warning with newer versions (jonasbb/serde_with#502) so I just removed it.
ghedo
added a commit
to cloudflare/quiche
that referenced
this pull request
Feb 20, 2025
This bumps url to match the versions specified in the workspace. It also appears that the `serde_with` dependency was entirely unnecessary, as the `serde_as` use in the code never actually worked properly and it triggers a warning with newer versions (jonasbb/serde_with#502) so I just removed it.
ghedo
added a commit
to cloudflare/quiche
that referenced
this pull request
Feb 21, 2025
This bumps url to match the versions specified in the workspace. It also appears that the `serde_with` dependency was entirely unnecessary, as the `serde_as` use in the code never actually worked properly and it triggers a warning with newer versions (jonasbb/serde_with#502) so I just removed it.
ghedo
added a commit
to cloudflare/quiche
that referenced
this pull request
Feb 21, 2025
This bumps url to match the versions specified in the workspace. It also appears that the `serde_with` dependency was entirely unnecessary, as the `serde_as` use in the code never actually worked properly and it triggers a warning with newer versions (jonasbb/serde_with#502) so I just removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the serde_as macro to warn on serde_as attributes on enum variant
fields. They are unsupported (in contrast to serde_derive), so showing
an error is better and avoids confusion when migrating.
Also update the main examples to include an enum.
Closes #499