Fix bug causing background crashes #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "saveState" method on WebView will persistent the entire contents of the webview and info about the backstack. This can rack up megabytes worth of data. The bundle limit is about 500KB. The fix is to only save the scroll-y position and rebuild the webview from other state. This prevents the bundle size from exceeding the max size of an integer.
jocmp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "saveState" method on WebView will persistent the entire contents of the webview and info about the backstack. This can rack up megabytes worth of data. The bundle limit is about 500KB.
The fix is to only save the scroll-y position and rebuild the webview from other state. This prevents the bundle size from exceeding the max size of an integer.
Ref: https://developer.android.com/reference/android/os/TransactionTooLargeException
Link #179, Closes #184