Setting a different pager for diff and log

[dsander]

Hi!

I would like to use a different page for jj log and jj diff, the diff should use delta and log should use :builtin. I started with adding a --scope for delta, which worked well:

[[--scope]]
"--when.commands" = ["diff"]

[--scope.ui]
pager = "delta"
[--scope.ui.diff]
format = "git"

I then discovered the :builtin pager option and wanted to try it out, setting ui.pager does not work (it defaults to $PAGER) for jj log.

[[--scope]]
"--when.commands" = ["diff"]

[--scope.ui]
pager = "delta"
[--scope.ui.diff]
format = "git"

[ui]
pager = ":builtin"

Trying to use another --scope for log also doesn't work, now jj diff is back to the default output and jj log uses the :builtin pager:

[[--scope]]
"--when.commands" = ["diff"]

[--scope.ui]
pager = "delta"
[--scope.ui.diff]
format = "git"

[[--scope]]
"--when.commands" = ["log"]

[--scope.ui]
pager = ":builtin"

If I reverse the order of the diff and log scopes in the configuration, I get the desired output for jj diff. I am probably missing something, it seems like the pager for diff and log are somehow connected and can not be change individually using --when.commands.

[yuja]

[[--scope]]
"--when.commands" = ["diff"]

If it isn't a copy-paste error, you have unnecessary quotes around the config key. It should be

--when.commands = ["diff"]

(If no conditions are specified, the last --scope-d variables win.)

[dsander]

Thank you! It wasn't a copy and paste error, but a misunderstanding about how nix attribute sets are converted into TOML and how TOML keys are interpreted.

I switched to providing the config as TOML and this works as expected:

  programs.jujutsu = {
    enable = true;
    package = unstablePkgs.jujutsu;
    settings = builtins.fromTOML ''
      [user]
      email = "...."
      name = "...."

      [ui]
      pager = ":builtin"

      [[--scope]]
      --when.commands = ["diff"]

      [--scope.ui]
      pager = "delta"
      [--scope.ui.diff]
      format = "git"
    '';
  };