Skip to content

fix (server.Stop): graciously handle various Stop() states. #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jimlambrt merged 1 commit into from
Jun 21, 2023
Merged

fix (server.Stop): graciously handle various Stop() states. #46

jimlambrt merged 1 commit into from
Jun 21, 2023

Conversation

@jimlambrt
Copy link
Owner

@jimlambrt jimlambrt commented Jun 21, 2023

see: #45

jimlambrt
jimlambrt commented Jun 21, 2023
View reviewed changes
Copy link
Owner Author

@jimlambrt jimlambrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable.

@jimlambrt jimlambrt requested a review from jefferai June 21, 2023 19:09
jefferai
jefferai approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimlambrt jimlambrt merged commit 74e9b22 into main Jun 21, 2023
@jefferai jefferai deleted the jimlambrt-stop-fix branch June 22, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jefferai jefferai jefferai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimlambrt @jefferai