Skip to content

Conversation

b-dean
Copy link
Contributor

@b-dean b-dean commented Jul 30, 2025

PR Checklist

  • CHANGELOG.md updated
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:

Whenever customIngress is specified, helm gives a warning about merging incompatible types (string and map).

Which issue this PR fixes:

fixes #2020

Special notes for your reviewer:
You can test the change before and after this values.yaml change with:

# before
helm template \
  --set customIngress.foo=bar \
  --set ingress.enabled=true \
  --show-only=templates/ingress.yaml \
  --version 107.111.12 \
  jfrog/artifactory

# after
helm dependency build stable/artifactory
helm template \
  --set customIngress.foo=bar \
  --set ingress.enabled=true \
  --show-only=templates/ingress.yaml \
  ./stable/artifactory

Copy link

github-actions bot commented Jul 30, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@b-dean b-dean force-pushed the fix/customIngress-default-value branch from 3e1cf76 to 67ee835 Compare July 30, 2025 14:22
@oumkale
Copy link
Member

oumkale commented Aug 7, 2025

Hi @b-dean,

Thank you for this PR. We will review it internally and provide an update once it is released.

@oumkale oumkale self-requested a review August 7, 2025 10:03
@b-dean b-dean force-pushed the fix/customIngress-default-value branch from 67ee835 to d01f236 Compare August 12, 2025 14:55
@b-dean b-dean force-pushed the fix/customIngress-default-value branch from d01f236 to ff88123 Compare August 26, 2025 14:43
@chukka
Copy link
Collaborator

chukka commented Sep 1, 2025

@b-dean This will be part of 7.117.x patch this week

@chukka chukka requested review from chukka and removed request for oumkale September 1, 2025 04:32
@chukka chukka changed the base branch from master to platform/11.2.2 September 3, 2025 06:41
@chukka chukka merged commit f8c5164 into jfrog:platform/11.2.2 Sep 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

customIngress default value is wrong type
3 participants