Don't hide errors from EM::HttpRequest #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 12, 2016 11:42
Owner
|
Thanks so much Paul! (And thanks for fixing the specs - not sure when they got broken) Would you have time to write a couple of test cases covering exception raising? Would really appreciate it if you could. |
Owner
|
Actually I added a test case. Thanks again for your contribution! |
Contributor
Author
|
Thanks for the review James :)! And thanks for the time taken to add tests and the Travis build I'm glad you also released and bump a new version with the patch. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it strange to hide all the details of the http errors into a generic exception raising an "EM - unknown error".
This PR raises the error from the EM::HttpRequest object instead