Add SHA256 checksum to GitHub release #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
May 1, 2024
Co-authored-by: Tim Jacomb <[email protected]>
timja
approved these changes
May 1, 2024
Member
timja
left a comment
timja
left a comment
There was a problem hiding this comment.
LGTM, I've tested the fetch artifact bits locally in my shell.
would you like a release now?
Member
Author
|
Sure, a release would be great as I intend to consume this from wherever we fetch this JAR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done
Tested the changes to
fetch-artifactend-to-end in GitHub Actions.Did not test the changes to
upload-release-asset, but those match our usage in Jenkins core and should be easy to debug in case of any issues the next time we perform a release.