Added download directory option in second example #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
requested changes
Nov 30, 2023
README.md
Outdated
| docker cp /your/path/to/plugins.txt <container_name>:/tmp/plugins.txt | ||
| docker exec -it <container_name> /bin/bash | ||
| jenkins-plugin-cli --plugin-file /your/path/to/plugins.txt --plugins delivery-pipeline-plugin:1.3.2 deployit-plugin | ||
| jenkins-plugin-cli --plugin-download-directory /your/path/to/plugins/ --plugin-file /tmp/plugins.txt --plugins delivery-pipeline-plugin:1.3.2 deployit-plugin |
Contributor
There was a problem hiding this comment.
The plugin-download-directory argument is not helpful for the docker case. The default download directory is already the correct location. The cp command is necessary because the default download location contents need to be copied to the runtime location
However, the cp command needs to be checked with the Alpine container image to be sure that the cp command on Alpine accepts the -r -p arguments and behaves as expected.
Suggested change
| jenkins-plugin-cli --plugin-download-directory /your/path/to/plugins/ --plugin-file /tmp/plugins.txt --plugins delivery-pipeline-plugin:1.3.2 deployit-plugin | |
| jenkins-plugin-cli --plugin-file /tmp/plugins.txt --plugins delivery-pipeline-plugin:1.3.2 deployit-plugin | |
| cp -r -p /usr/share/jenkins/ref/plugins/. /var/jenkins_home/plugins/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added download directory option in second example in README.md
Submitter checklist