Skip to content

Conversation

@MarkEWaite
Copy link
Contributor

Add spotbugs checks

  • Redundant null check removed
  • Enable spotbugs with exclusions
  • Exclude a spotbugs warning only visible on recent weekly

Provide an exclusions file that excludes the existing spotbugs warnings so that new warnings won't be introduced undetected.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Prevent further spotbugs warnings from being introduced and allow
contributors to resolve one or two warnings at a time.
Open files on a path is reported in an additional location with
Jenkins 2.371
@MarkEWaite MarkEWaite enabled auto-merge November 8, 2022 00:47
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.
Impressive excludesFilter.xml by the way. 👍

@MarkEWaite MarkEWaite merged commit 364aff4 into jenkinsci:master Nov 8, 2022
@MarkEWaite MarkEWaite deleted the add-spotbugs-checks branch November 8, 2022 12:35
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Reduces maintenance effort by changes not directly visible to users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants