Skip to content

Conversation

@bitshop
Copy link
Collaborator

@bitshop bitshop commented Jul 8, 2018

Please try this and give some feedback, given I think OP way you can override anytime is FAR better than AP this is definitely how I prefer it work.. But the difference w/ AP will seem abnormal at first to anyone who is used to AP.. I think they'll quickly like it better.

@jeankalud
Copy link
Owner

I run this pull request on my car. Its a step in the right direction IMHO, but not ready for prime time. I had multiple event of engage-disengage-engage-disengage at 0.5 sec intervals, like "fighting" the system. Its not really fighting as the EPAS is super easy on the user and the user always have the last word, but it was kind of not working well in some conditions. Also, for lane changes I fell like its much better with signals disabling temporarily. I mean, its not smooth for passenger compared of what's in the current branch.

One idea I had is trying to smooth out re-engagement but temporarily reducing Kp/Ki gains for a second after re-engaging. Something like that would helps.

@bitshop
Copy link
Collaborator Author

bitshop commented Jul 10, 2018

Making a new request, closing this one.

@bitshop bitshop closed this Jul 10, 2018
DavidWAbrahams pushed a commit to DavidWAbrahams/openpilot that referenced this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants