find_ue convergence check and results return #57
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ODME example with existing UE conducts odme before reading measurements
fix error regarding ODME in usecases.md - read_measurements() shall be invoked before conduct_odme().
reenable warnings when missing pyyaml or settings.yml
Use the default .gitignore for python projects as basis
jdlph
added a commit
that referenced
this pull request
Mar 16, 2025
- optimize _update_column_attributes() on calculating the total system travel time and the final relative gap; - remove useless read_demand_matrix() from io.py; - conduct minor cosmetic changes to path.py.
Owner
|
The enhancement suggestions from this PR on returning relative gap and passing rel_gap_tolerance to find_ue() have been manually incorporated in v0.9.10. This PR is closed now. Thank you again for opening up this PR and inspiring us to improve Path4GMNS!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_ueaccepts arel_gap_tolernaceparameter to stop the optimization if a relative gap tolerance has been achieved.Moreover
find_uereturns the convergence results (total_gap, rel_gap and iteration number)