Attic doesn't handle connections issues when using remote repo

[thiagoc]

This is how I'm testing:

• Run attic create ... in one terminal
• Wait some minutes
• Run conntrack -D -p tcp --dport 22 in another terminal

Attic is still running (??) after some minutes. Hit CTRL+C, it display attic: Error: Keyboard interrupt but doesn't stop after some more minutes. Hit CTRL+C again and:

Exception ignored in: <bound method RemoteRepository.__del__ of <attic.remote.RemoteRepository object at 0x7f6d230fecc0>>
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/site-packages/attic/remote.py", line 124, in __del__
    self.close()
  File "/usr/local/lib/python3.4/site-packages/attic/remote.py", line 243, in close
    self.p.wait()
  File "/usr/local/lib/python3.4/subprocess.py", line 1565, in wait
    (pid, sts) = self._try_wait(0)
  File "/usr/local/lib/python3.4/subprocess.py", line 1513, in _try_wait
    (pid, sts) = _eintr_retry_call(os.waitpid, self.pid, wait_flags)
  File "/usr/local/lib/python3.4/subprocess.py", line 491, in _eintr_retry_call
    return func(*args)
KeyboardInterrupt: 

[ThomasWaldmann]

This report seems to be rather related to how KeyboardInterrupt was handled than connection issues (as the issue title says).

attic.archiver.main catches KeyboardInterrupt exception and shows the Error: Keyboad Interrupt. After that (in current code), it just does sys.exit(1).

So, can you clarify / reproduce with current code?

[ThomasWaldmann]

In .close() it closes stdin/stdout pipes and then waits for the ssh subprocess to terminate.

In your case, ssh seems unwilling to terminate, so maybe giving that timeout argument to .wait() would help a little with that.

https://docs.python.org/3/library/subprocess.html#subprocess.Popen.wait

Hmm, not sure any more if that is a good idea - esp. for cases when close is called and it is not due to Ctrl-C, but within normal operations...