Skip to content

Conversation

@oulgen
Copy link

@oulgen oulgen commented Dec 30, 2025

Needed to enable more PyTorch Inductor mgpu tests like pytorch/pytorch#171485

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @oulgen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the functional capabilities of the Mosaic GPU backend by integrating several fundamental mathematical operations and reduction primitives. These additions are crucial for enhancing JAX's compatibility with PyTorch Inductor, allowing for a broader range of computations to be efficiently compiled and executed on GPUs. The changes involve updating lowering rules, extending the FragmentedArray API, and ensuring robust test coverage for the new functionalities.

Highlights

  • New Math Operations: Added support for abs, sign, erf, and atan2 operations within the Mosaic GPU lowering rules.
  • Reduction Operations: Introduced support for reduce_min and reduce_prod operations, including their resource estimation and lowering rules for both Lane and Warpgroup semantics.
  • FragmentedArray Enhancements: Implemented corresponding abs, sign, erf, atan2, min, and prod methods directly within the FragmentedArray class for efficient GPU execution.
  • Comprehensive Testing: Expanded the test suite with new tests for sign, atan2, reduce_min, and reduce_prod, and updated existing unary operation tests to cover abs and erf.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for abs, sign, erf, atan2, reduce_min, and reduce_prod to Mosaic GPU, which is a great enhancement. The implementation looks solid and is accompanied by relevant tests. I have a couple of suggestions to refactor some duplicated code in the lowering rules for better maintainability. Additionally, I've pointed out a missing test case for unsigned integers in the sign operation test.

@oulgen
Copy link
Author

oulgen commented Dec 30, 2025

I don't have permissions to add reviewers, so here it goes: @sharadmv @voznesenskym @apaszke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant