Skip to content

Conversation

@pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Jan 22, 2025

The GitHub workflow that Janet runs to check code quality began failing with the merge of #1544 on 12 January 2025. This workflow uses version 2 of various CodeQL actions. According to this blog post, these actions were ‘retired’ on 10 January 2025.

This PR changes the version from 2 to 3. This is the latest version at the time of this PR.

@pyrmont
Copy link
Contributor Author

pyrmont commented Jan 22, 2025

This hasn’t fixed the problem. My apologies. The code quality workflow only runs on PRs so I couldn’t test it beforehand. I’m trying again to find the source of problem.

@sogaiu
Copy link
Contributor

sogaiu commented Jan 22, 2025

That does seem odd.

At first glance, the changes in this PR look like those described in the blog post.

@pyrmont
Copy link
Contributor Author

pyrmont commented Jan 22, 2025

In a direct message, @sogaiu pointed out that it might be related to github/codeql-action#2701. I’ll wait to see if the update to v2.20.2 fixes it when that’s rolled out (apparently) later this week.

@pyrmont pyrmont marked this pull request as draft January 22, 2025 15:29
@pyrmont
Copy link
Contributor Author

pyrmont commented Jan 23, 2025

The new version of CodeQL has fixed the problem. I followed the suggestion here and adding tools: linked has forced the workflow to use v2.20.2 of CodeQL.

@pyrmont pyrmont marked this pull request as ready for review January 23, 2025 19:07
@bakpakin bakpakin merged commit 1f34ec9 into janet-lang:master Jan 25, 2025
13 checks passed
@pyrmont pyrmont deleted the bugfix.codeql-upgrade branch January 25, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants