[clickhouse] Implement factory with minimal configuration #7518

mahadzaryab1 · 2025-09-23T22:55:43Z

Which problem is this PR solving?

Towards [clickhouse] Implement Factory For ClickHouse Storage #7137

Description of the changes

This PR adds a factory for ClickHouse storage with very minimal configuration. In the follow-up PRs, we'll need to do the following:
- Auto-create schema
- Expose more customizations for ClickHouse through the configuration
- Call into the factory from the storage extension
- Add E2E tests

How was this change tested?

Added unit tests

Checklist

I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
I have signed all commits
I have added unit tests for the new functionality
I have run lint and test steps successfully
- for jaeger: make lint test
- for jaeger-ui: npm run lint and npm run test

Signed-off-by: Mahad Zaryab <[email protected]>

codecov · 2025-09-23T23:03:42Z

Codecov Report

❌ Patch coverage is 93.87755% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.59%. Comparing base (c553527) to head (6db004e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ternal/storage/v2/clickhouse/tracestore/factory.go	92.85%	2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (93.87%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7518      +/-   ##
==========================================
- Coverage   96.60%   96.59%   -0.01%     
==========================================
  Files         381      383       +2     
  Lines       23189    23238      +49     
==========================================
+ Hits        22401    22447      +46     
- Misses        600      602       +2     
- Partials      188      189       +1

Flag	Coverage Δ
badger_v1	`9.02% <ø> (ø)`
badger_v2	`1.70% <ø> (ø)`
cassandra-4.x-v1-manual	`11.67% <ø> (ø)`
cassandra-4.x-v2-auto	`1.69% <ø> (ø)`
cassandra-4.x-v2-manual	`1.69% <ø> (ø)`
cassandra-5.x-v1-manual	`11.67% <ø> (ø)`
cassandra-5.x-v2-auto	`1.69% <ø> (ø)`
cassandra-5.x-v2-manual	`1.69% <ø> (ø)`
elasticsearch-6.x-v1	`16.57% <ø> (ø)`
elasticsearch-7.x-v1	`16.61% <ø> (ø)`
elasticsearch-8.x-v1	`16.75% <ø> (ø)`
elasticsearch-8.x-v2	`1.70% <ø> (ø)`
elasticsearch-9.x-v2	`1.70% <ø> (ø)`
grpc_v1	`10.22% <ø> (ø)`
grpc_v2	`1.70% <ø> (ø)`
kafka-3.x-v1	`9.66% <ø> (ø)`
kafka-3.x-v2	`1.70% <ø> (ø)`
memory_v2	`1.70% <ø> (ø)`
opensearch-1.x-v1	`16.66% <ø> (ø)`
opensearch-2.x-v1	`16.66% <ø> (ø)`
opensearch-2.x-v2	`1.70% <ø> (ø)`
opensearch-3.x-v2	`1.70% <ø> (ø)`
query	`1.70% <ø> (ø)`
tailsampling-processor	`0.46% <ø> (ø)`
unittests	`95.58% <93.87%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-09-23T23:05:24Z

Metrics Comparison Summary

Total changes across all snapshots: 106

Detailed changes per snapshot

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 53

🆕 Added: 0 metrics
❌ Removed: 53 metrics
🔄 Modified: 0 metrics

❌ Removed Metrics

http_server_request_body_size_bytes (18 variants)

View diff sample

-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_request_duration_seconds` (17 variants)

View diff sample

-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.005",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.01",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.025",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.05",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.075",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.1",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_response_body_size_bytes` (18 variants)

View diff sample

-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

### summary_metrics_snapshot_cassandra ## 📊 Metrics Diff Summary

Total Changes: 53

🆕 Added: 0 metrics
❌ Removed: 53 metrics
🔄 Modified: 0 metrics

❌ Removed Metrics

http_server_request_body_size_bytes (18 variants)

View diff sample

-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_request_duration_seconds` (17 variants)

View diff sample

-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.005",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.01",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.025",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.05",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.075",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.1",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_response_body_size_bytes` (18 variants)

View diff sample

-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

➡️ View full metrics file

Signed-off-by: Mahad Zaryab <[email protected]>

internal/storage/v2/clickhouse/tracestore/factory.go

mahadzaryab1 · 2025-09-26T21:35:42Z

internal/storage/v2/clickhouse/tracestore/factory.go

+}
+
+func (f *Factory) Close() error {
+	if err := f.conn.Close(); err != nil {


doesn't return an error

func (h *httpConnect) close() error { if h.client == nil { return nil } h.client.CloseIdleConnections() h.client = nil return nil }

Signed-off-by: Mahad Zaryab <[email protected]>

yurishkuro · 2025-09-26T21:51:47Z

internal/storage/v2/clickhouse/tracestore/config.go

+	// Database is the ClickHouse database to connect to.
+	Database string `mapstructure:"database"`
+	// Username is the username to connect to ClickHouse.
+	Username string `mapstructure:"username"`
+	// Password is the password to connect to ClickHouse.
+	Password string `mapstructure:"password"`


is basic auth the only way to connect? Usually we structure overall Auth as Basic+other types.

even better, we should really switch to using configauth and auth-n extensions

https://pkg.go.dev/go.opentelemetry.io/collector/config/configauth#section-readme

Yeah I only see basic auth for ClickHouse. Do we want to make that switch in this PR?

If it's an easy enough switch than I'd prefer to do it now, for future extensibility and overall alignment w/ OTEL's mechanisms. There's another open PR that brings in sigv4 extension, so for ES we should also switch to configauth.

I updated to use OTEL's config struct here. There's also JWT auth which I can add in a follow-up PR.

internal/storage/v2/clickhouse/tracestore/config.go

go.mod

Signed-off-by: Mahad Zaryab <[email protected]>

yurishkuro · 2025-09-27T22:15:18Z

internal/storage/v2/clickhouse/tracestore/factory.go

+	}
+	conn, err := clickhouse.Open(opts)
+	if err != nil {
+		defer conn.Close()


if error is returned conn could be nil. Normally you just return, you don't try to close it.

yurishkuro · 2025-09-27T22:15:51Z

internal/storage/v2/clickhouse/tracestore/factory.go

+	if err := f.conn.Close(); err != nil {
+		return fmt.Errorf("failed to close ClickHouse connection: %w", err)


Suggested change

if err := f.conn.Close(); err != nil {

return fmt.Errorf("failed to close ClickHouse connection: %w", err)

return f.conn.Close()

yurishkuro · 2025-09-27T22:17:05Z

internal/storage/v2/clickhouse/tracestore/factory.go

+	}
+	err = conn.Ping(ctx)
+	if err != nil {
+		defer conn.Close()


Suggested change

defer conn.Close()

conn.Close()

yurishkuro · 2025-09-27T22:18:08Z

internal/storage/v2/clickhouse/tracestore/factory.go

+		defer conn.Close()
+		return nil, fmt.Errorf("failed to ping ClickHouse: %w", err)


another option

Suggested change

defer conn.Close()

return nil, fmt.Errorf("failed to ping ClickHouse: %w", err)

return nil, errors.Join(

fmt.Errorf("failed to ping ClickHouse: %w", err),

conn.Close(),

)

Signed-off-by: Mahad Zaryab <[email protected]>

mahadzaryab1 added 4 commits September 23, 2025 18:40

Add Config

326e274

Signed-off-by: Mahad Zaryab <[email protected]>

Add Missing Methods

e56f8a4

Signed-off-by: Mahad Zaryab <[email protected]>

Fix Type

e5521af

Signed-off-by: Mahad Zaryab <[email protected]>

Implement Factory With Minimal Config

413dcab

Signed-off-by: Mahad Zaryab <[email protected]>

mahadzaryab1 added the changelog:exprimental Change to an experimental part of the code label Sep 23, 2025

mahadzaryab1 added 2 commits September 23, 2025 19:35

Add Unit Tests For New Reader Functions

7cde161

Signed-off-by: Mahad Zaryab <[email protected]>

Add Dependency on go-testcontainer

5a3c6d8

Signed-off-by: Mahad Zaryab <[email protected]>

mahadzaryab1 force-pushed the clickhouse-factory branch from 63c4fc6 to 5a3c6d8 Compare September 24, 2025 01:25

mahadzaryab1 added 18 commits September 23, 2025 21:49

Add Test For Factory

d39e67d

Signed-off-by: Mahad Zaryab <[email protected]>

Add Ping

b7a51ea

Signed-off-by: Mahad Zaryab <[email protected]>

Add Tests

2511d4a

Signed-off-by: Mahad Zaryab <[email protected]>

Add XML Configuration File For ClickHouse Users

3147cf5

Signed-off-by: Mahad Zaryab <[email protected]>

Update Test To Add Password

3a43513

Signed-off-by: Mahad Zaryab <[email protected]>

Add License

7b727c5

Signed-off-by: Mahad Zaryab <[email protected]>

Fix

4f9f1c0

Signed-off-by: Mahad Zaryab <[email protected]>

Revert Adding Dependency

5afc70d

Signed-off-by: Mahad Zaryab <[email protected]>

Remove Old Factory Tests

b2cdccb

Signed-off-by: Mahad Zaryab <[email protected]>

Revert .gitignore

e32f1ec

Signed-off-by: Mahad Zaryab <[email protected]>

Remove ClickHouse Configuration File

46e0f29

Signed-off-by: Mahad Zaryab <[email protected]>

Expose Protocol In Config

94b5313

Signed-off-by: Mahad Zaryab <[email protected]>

Add Protocol

2568c01

Signed-off-by: Mahad Zaryab <[email protected]>

Fix Unit Tests

9bb4b50

Signed-off-by: Mahad Zaryab <[email protected]>

Update Dependencies

0f7fd5f

Signed-off-by: Mahad Zaryab <[email protected]>

Simplify Unit Test

07c5097

Signed-off-by: Mahad Zaryab <[email protected]>

Add Unit Tests For Config Validation

849eddc

Signed-off-by: Mahad Zaryab <[email protected]>

Run Formatter

dbbde13

Signed-off-by: Mahad Zaryab <[email protected]>

mahadzaryab1 commented Sep 26, 2025

View reviewed changes

internal/storage/v2/clickhouse/tracestore/factory.go Show resolved Hide resolved

mahadzaryab1 commented Sep 26, 2025

View reviewed changes

mahadzaryab1 changed the title ~~[WIP][clickhouse] Implement factory with minimal configuration~~ [clickhouse] Implement factory with minimal configuration Sep 26, 2025

Fix

08de4e5

Signed-off-by: Mahad Zaryab <[email protected]>

mahadzaryab1 marked this pull request as ready for review September 26, 2025 21:41

mahadzaryab1 requested a review from a team as a code owner September 26, 2025 21:41

mahadzaryab1 requested a review from jkowall September 26, 2025 21:41

dosubot bot added area/storage v2 labels Sep 26, 2025

yurishkuro reviewed Sep 26, 2025

View reviewed changes

internal/storage/v2/clickhouse/tracestore/config.go Show resolved Hide resolved

yurishkuro reviewed Sep 26, 2025

View reviewed changes

go.mod Show resolved Hide resolved

mahadzaryab1 added 5 commits September 26, 2025 20:59

Add Dependency On basicauthextension

d3b92c4

Signed-off-by: Mahad Zaryab <[email protected]>

Use OTEL Struct For Basic Auth

32924bc

Signed-off-by: Mahad Zaryab <[email protected]>

Update Tests

61f7c8c

Signed-off-by: Mahad Zaryab <[email protected]>

Use Same Version

b95dfe9

Signed-off-by: Mahad Zaryab <[email protected]>

Minimize Diff

dacbb4f

Signed-off-by: Mahad Zaryab <[email protected]>

mahadzaryab1 requested a review from yurishkuro September 27, 2025 01:43

Fix

ec1d5b8

Signed-off-by: Mahad Zaryab <[email protected]>

yurishkuro reviewed Sep 27, 2025

View reviewed changes

Address Feedback

6db004e

Signed-off-by: Mahad Zaryab <[email protected]>

mahadzaryab1 requested a review from yurishkuro September 27, 2025 22:23

yurishkuro approved these changes Sep 27, 2025

View reviewed changes

yurishkuro merged commit a9bfd75 into jaegertracing:main Sep 27, 2025
63 of 64 checks passed

		if err := f.conn.Close(); err != nil {
		return fmt.Errorf("failed to close ClickHouse connection: %w", err)

	if err := f.conn.Close(); err != nil {
	return fmt.Errorf("failed to close ClickHouse connection: %w", err)
	return f.conn.Close()

		defer conn.Close()
		return nil, fmt.Errorf("failed to ping ClickHouse: %w", err)

-		defer conn.Close()
-		return nil, fmt.Errorf("failed to ping ClickHouse: %w", err)
+		return nil, errors.Join(
+		  fmt.Errorf("failed to ping ClickHouse: %w", err),
+		  conn.Close(),
+		)

[clickhouse] Implement factory with minimal configuration #7518

[clickhouse] Implement factory with minimal configuration #7518

Uh oh!

Conversation

mahadzaryab1 commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Uh oh!

codecov bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Metrics Comparison Summary

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

❌ Removed Metrics

❌ Removed Metrics

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yurishkuro Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mahadzaryab1 commented Sep 23, 2025 •

edited

Loading

codecov bot commented Sep 23, 2025 •

edited

Loading

github-actions bot commented Sep 23, 2025 •

edited

Loading

yurishkuro Sep 27, 2025 •

edited

Loading