Skip to content

Conversation

@mmorel-35
Copy link
Contributor

Which problem is this PR solving?

  • enable rangeValCopy from go-critic

Description of the changes

How was this change tested?

Checklist

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.44%. Comparing base (022a5ea) to head (e3ac0fd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7438      +/-   ##
==========================================
- Coverage   96.46%   96.44%   -0.03%     
==========================================
  Files         377      377              
  Lines       23090    23092       +2     
==========================================
- Hits        22274    22271       -3     
- Misses        618      622       +4     
- Partials      198      199       +1     
Flag Coverage Δ
badger_v1 9.02% <0.00%> (-0.01%) ⬇️
badger_v2 1.70% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1-manual 11.68% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2-auto 1.69% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2-manual 1.69% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1-manual 11.68% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2-auto 1.69% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2-manual 1.69% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 16.58% <0.00%> (-0.01%) ⬇️
elasticsearch-7.x-v1 16.62% <0.00%> (-0.01%) ⬇️
elasticsearch-8.x-v1 16.77% <0.00%> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.70% <0.00%> (-0.01%) ⬇️
elasticsearch-9.x-v2 1.70% <0.00%> (-0.01%) ⬇️
grpc_v1 10.22% <100.00%> (+<0.01%) ⬆️
grpc_v2 1.70% <0.00%> (-0.01%) ⬇️
kafka-3.x-v1 9.67% <0.00%> (-0.01%) ⬇️
kafka-3.x-v2 1.70% <0.00%> (-0.01%) ⬇️
memory_v2 1.70% <0.00%> (-0.01%) ⬇️
opensearch-1.x-v1 16.67% <0.00%> (-0.01%) ⬇️
opensearch-2.x-v1 16.67% <0.00%> (-0.01%) ⬇️
opensearch-2.x-v2 1.70% <0.00%> (-0.01%) ⬇️
opensearch-3.x-v2 1.70% <0.00%> (-0.01%) ⬇️
query 1.70% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.47% <0.00%> (-0.01%) ⬇️
unittests 95.43% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmorel-35 mmorel-35 force-pushed the gocritic/rangeValCopy branch from 0326b04 to e3ac0fd Compare August 12, 2025 07:08
@mmorel-35 mmorel-35 marked this pull request as ready for review August 12, 2025 07:29
@mmorel-35 mmorel-35 requested a review from a team as a code owner August 12, 2025 07:29
@mmorel-35 mmorel-35 requested a review from yurishkuro August 12, 2025 07:29
@dosubot dosubot bot added the area/storage label Aug 12, 2025
@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Aug 12, 2025
@yurishkuro yurishkuro added this pull request to the merge queue Aug 12, 2025
Merged via the queue into jaegertracing:main with commit 0565ca2 Aug 12, 2025
64 of 66 checks passed
@mmorel-35 mmorel-35 deleted the gocritic/rangeValCopy branch August 12, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/storage changelog:refactoring Internal code refactoring without functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants