-
Notifications
You must be signed in to change notification settings - Fork 2.7k
chore: enable more rules from go-critic #7434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7434 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 377 377
Lines 23090 23090
=======================================
Hits 22269 22269
Misses 622 622
Partials 199 199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
949d699 to
0ac76f0
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
195cc8f to
1ac22f0
Compare
| - hugeParam | ||
| - importShadow | ||
| - nestingReduce | ||
| - paramTypeCombine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a bad linter and I would not want to enable it. (a string, b string, ...) is A LOT easier to read than dropping repeated types. With explicit types it's obvious, with combined types I need to scan more of the string to figure out the types, and the use of commas isn't helping.
Signed-off-by: Matthieu MOREL <[email protected]>
1ac22f0 to
a094714
Compare
a094714 to
b13544d
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
b13544d to
8c2fd3c
Compare
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test