Skip to content

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Aug 11, 2025

Which problem is this PR solving?

Description of the changes

  • Enable more rules from go-critic

How was this change tested?

Checklist

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 96.77419% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.44%. Comparing base (a5de984) to head (8c2fd3c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nal/sampling/samplingstrategy/adaptive/provider.go 75.00% 2 Missing ⚠️
internal/storage/v1/memory/memory.go 88.88% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7434   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files         377      377           
  Lines       23090    23090           
=======================================
  Hits        22269    22269           
  Misses        622      622           
  Partials      199      199           
Flag Coverage Δ
badger_v1 9.02% <5.26%> (ø)
badger_v2 1.70% <0.00%> (ø)
cassandra-4.x-v1-manual 11.68% <19.29%> (ø)
cassandra-4.x-v2-auto 1.69% <0.00%> (ø)
cassandra-4.x-v2-manual 1.69% <0.00%> (ø)
cassandra-5.x-v1-manual 11.68% <19.29%> (ø)
cassandra-5.x-v2-auto 1.69% <0.00%> (ø)
cassandra-5.x-v2-manual 1.69% <0.00%> (ø)
elasticsearch-6.x-v1 16.58% <1.75%> (ø)
elasticsearch-7.x-v1 16.63% <1.75%> (ø)
elasticsearch-8.x-v1 16.77% <1.75%> (ø)
elasticsearch-8.x-v2 1.70% <0.00%> (ø)
elasticsearch-9.x-v2 1.70% <0.00%> (ø)
grpc_v1 10.21% <28.07%> (ø)
grpc_v2 1.70% <0.00%> (ø)
kafka-3.x-v1 9.68% <14.03%> (ø)
kafka-3.x-v2 1.70% <0.00%> (ø)
memory_v2 1.70% <0.00%> (ø)
opensearch-1.x-v1 16.67% <1.75%> (ø)
opensearch-2.x-v1 16.67% <1.75%> (ø)
opensearch-2.x-v2 1.70% <0.00%> (ø)
opensearch-3.x-v2 1.70% <0.00%> (ø)
query 1.70% <0.00%> (ø)
tailsampling-processor 0.47% <0.00%> (ø)
unittests 95.43% <96.77%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmorel-35 mmorel-35 force-pushed the gocritic/more branch 2 times, most recently from 195cc8f to 1ac22f0 Compare August 11, 2025 16:34
@mmorel-35 mmorel-35 marked this pull request as ready for review August 11, 2025 16:44
@mmorel-35 mmorel-35 requested a review from a team as a code owner August 11, 2025 16:44
@mmorel-35 mmorel-35 requested a review from jkowall August 11, 2025 16:44
@mmorel-35 mmorel-35 changed the title chore: enable more rule from go-critic chore: enable more rules from go-critic Aug 11, 2025
@dosubot dosubot bot added the go label Aug 11, 2025
@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Aug 11, 2025
- hugeParam
- importShadow
- nestingReduce
- paramTypeCombine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a bad linter and I would not want to enable it. (a string, b string, ...) is A LOT easier to read than dropping repeated types. With explicit types it's obvious, with combined types I need to scan more of the string to figure out the types, and the use of commas isn't helping.

@mmorel-35 mmorel-35 marked this pull request as draft August 11, 2025 18:22
@mmorel-35 mmorel-35 marked this pull request as ready for review August 11, 2025 19:12
@dosubot dosubot bot added area/sampling area/storage storage/badger Issues related to badger storage labels Aug 11, 2025
@yurishkuro yurishkuro merged commit 022a5ea into jaegertracing:main Aug 11, 2025
67 checks passed
@mmorel-35 mmorel-35 deleted the gocritic/more branch August 11, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sampling area/storage changelog:refactoring Internal code refactoring without functional changes storage/badger Issues related to badger storage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants