-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Automate Jaeger Demo Deployment to OKE Using GitHub Actions #7334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
598abab
386cdd7
1ca266e
8bcd66b
722fe72
5cdcfbb
3592f60
a99681d
e3f4490
67489ce
a1cfd68
1e3131c
2b1d22d
9374695
10afa47
62b13d9
fa857dd
2afc09d
cd3d716
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,40 @@ | ||||||||||||||||||||||||||||||
| name: Deploy Jaeger Demo to OKE | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| on: | ||||||||||||||||||||||||||||||
| schedule: | ||||||||||||||||||||||||||||||
| - cron: '0 5 * * *' # Daily at 5 AM UTC | ||||||||||||||||||||||||||||||
| #testing | ||||||||||||||||||||||||||||||
| push: | ||||||||||||||||||||||||||||||
| branches: [main] | ||||||||||||||||||||||||||||||
| pull_request: | ||||||||||||||||||||||||||||||
| branches: [main] | ||||||||||||||||||||||||||||||
| workflow_dispatch: | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
yurishkuro marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||||||||||
| permissions: | ||||||||||||||||||||||||||||||
| secrets: read | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| jobs: | ||||||||||||||||||||||||||||||
| deploy: | ||||||||||||||||||||||||||||||
| name: Deploy Jaeger to OKE Cluster | ||||||||||||||||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||||||||||||||||
| env: | ||||||||||||||||||||||||||||||
| OCI_CLI_USER: ${{ secrets.OCI_CLI_USER }} | ||||||||||||||||||||||||||||||
| OCI_CLI_TENANCY: ${{ secrets.OCI_CLI_TENANCY }} | ||||||||||||||||||||||||||||||
| OCI_CLI_FINGERPRINT: ${{ secrets.OCI_CLI_FINGERPRINT }} | ||||||||||||||||||||||||||||||
| OCI_CLI_KEY_CONTENT: ${{ secrets.OCI_CLI_KEY_CONTENT }} | ||||||||||||||||||||||||||||||
| OCI_CLI_REGION: ${{ secrets.OCI_CLI_REGION }} | ||||||||||||||||||||||||||||||
yurishkuro marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| steps: | ||||||||||||||||||||||||||||||
| - name: Configure kubectl with OKE | ||||||||||||||||||||||||||||||
| uses: oracle-actions/[email protected] | ||||||||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||||||
| cluster: ${{ secrets.OKE_CLUSTER_OCID }} | ||||||||||||||||||||||||||||||
| enablePrivateEndpoint: false | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| - name: Clone Jaeger repository | ||||||||||||||||||||||||||||||
| run: git clone https://github.com/jaegertracing/jaeger.git | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
| - name: Clone Jaeger repository | |
| run: git clone https://github.com/jaegertracing/jaeger.git | |
| - name: Checkout code | |
| uses: actions/checkout@v3 |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
yurishkuro marked this conversation as resolved.
Show resolved
Hide resolved
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow should use actions/checkout@v3 instead of manually cloning the repository. The current approach creates a fresh clone rather than using the repository context where the workflow is running, which can cause path inconsistencies and doesn't reflect the actual code being submitted in the PR.
Consider replacing:
- name: Clone Jaeger repository
run: git clone https://github.com/jaegertracing/jaeger.git
- name: Deploy using Jaeger's deploy-all.sh
run: |
cd ./jaeger/examples/oci
bash ./deploy-all.shWith:
- name: Checkout repository
uses: actions/checkout@v3
- name: Deploy using Jaeger's deploy-all.sh
run: |
cd ./examples/oci
bash ./deploy-all.shThis ensures the workflow operates on the correct version of the code and simplifies the path references.
| - name: Clone Jaeger repository | |
| run: git clone https://github.com/jaegertracing/jaeger.git | |
| - name: Deploy using Jaeger's deploy-all.sh | |
| run: | | |
| cd ./jaeger/examples/oci | |
| bash ./deploy-all.sh | |
| - name: Checkout repository | |
| uses: actions/checkout@v3 | |
| - name: Deploy using Jaeger's deploy-all.sh | |
| run: | | |
| cd ./examples/oci | |
| bash ./deploy-all.sh |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the deploy fails I would rather it happens on US ET time, not at midnight .