[spm] Bug fix for metricstore/elasticsearch/processor.go

[pipiland2612]

Which problem is this PR solving?

• Fix 2 bugs of the current implementation in [W3]: Implement metricstore.Reader interface in elasticsearch #7147
  Bug 1: The current calcCallRate overvalue the call rate when after a long period of having no data, this is caused by setting
  if math.IsNaN(firstValue) { firstValue = 0 }

Reference images:

When compares to the working solution:

Some other timestamp & service:

Solution: Use lastNonNaNMap := make(map[string]float64) that tracks the lastNonNaN value associates with different labels key. When I rerun with this changes, the problem is now fixed:

When compares to the working solution:

Bug 2: Add 0 data point for service that don't return any data point for errorRate. This changes is made with zeroValue

Description of the changes

• Add lastNonNaNmap to fix bug 1
• Add zeroValue to fix bug 2

How was this change tested?

• CI

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: npm run lint and npm run test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.15%. Comparing base (6972da9) to head (a69d426).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7303      +/-   ##
==========================================
- Coverage   96.16%   96.15%   -0.02%     
==========================================
  Files         377      377              
  Lines       22863    22886      +23     
==========================================
+ Hits        21987    22006      +19     
- Misses        660      663       +3     
- Partials      216      217       +1     

Flag	Coverage Δ
badger_v1	9.17% <ø> (ø)
badger_v2	1.75% <0.00%> (-0.01%)	⬇️
cassandra-4.x-v1-manual	11.91% <ø> (ø)
cassandra-4.x-v2-auto	1.74% <0.00%> (-0.01%)	⬇️
cassandra-4.x-v2-manual	1.74% <0.00%> (-0.01%)	⬇️
cassandra-5.x-v1-manual	11.91% <ø> (ø)
cassandra-5.x-v2-auto	1.74% <0.00%> (-0.01%)	⬇️
cassandra-5.x-v2-manual	1.74% <0.00%> (-0.01%)	⬇️
elasticsearch-6.x-v1	16.66% <ø> (ø)
elasticsearch-7.x-v1	16.71% <ø> (ø)
elasticsearch-8.x-v1	16.87% <ø> (ø)
elasticsearch-8.x-v2	1.75% <0.00%> (-0.10%)	⬇️
grpc_v1	10.42% <ø> (ø)
grpc_v2	1.75% <0.00%> (-0.01%)	⬇️
kafka-3.x-v1	9.34% <ø> (ø)
kafka-3.x-v2	1.75% <0.00%> (-0.01%)	⬇️
memory_v2	1.75% <0.00%> (-0.01%)	⬇️
opensearch-1.x-v1	16.75% <ø> (ø)
opensearch-2.x-v1	16.75% <ø> (ø)
opensearch-2.x-v2	1.75% <0.00%> (-0.01%)	⬇️
query	1.75% <0.00%> (-0.01%)	⬇️
tailsampling-processor	0.48% <0.00%> (-0.01%)	⬇️
unittests	95.07% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.