-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[fix] Make EnableTracing param work correctly in jaeger-v2 query extension #7226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Make EnableTracing param work correctly in jaeger-v2 query extension #7226
Conversation
Signed-off-by: Murphy Chen <[email protected]>
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (77.27%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7226 +/- ##
==========================================
- Coverage 96.62% 96.61% -0.01%
==========================================
Files 378 378
Lines 23146 23154 +8
==========================================
+ Hits 22364 22371 +7
Misses 596 596
- Partials 186 187 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
In jaeger v1 we always had self-tracing on by default, so I'm not sure how that property was used. It needs to remain on by default with this change. |
|
@yurishkuro This PR will disable self-tracing by default. I've checked the latest Jaeger v1, and it is also disabled by default there. The screenshot is from 1.70 |
|
The v1 all-in-one has query tracing on by default, and so is jaeger-v2. |
Signed-off-by: Murphy Chen <[email protected]>
|
@yurishkuro Please review |
Signed-off-by: Murphy Chen <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time. |

Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test