-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add e2e test for docker-compose-elasticsearch.yml file #7145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test for docker-compose-elasticsearch.yml file #7145
Conversation
Signed-off-by: pipiland2612 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7145 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 358 358
Lines 21689 21689
=======================================
Hits 20870 20870
Misses 613 613
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: pipiland2612 <[email protected]>
Signed-off-by: pipiland2612 <[email protected]>
59348c7 to
d8317e4
Compare
Signed-off-by: pipiland2612 <[email protected]>
|
fyi - you may want to fix this in the follow-up PR (it's an old bug): This isn't actually an error, but a timing issue, the error would be only if there was no match after all the retries |
## Which problem is this PR solving? - Provide better log for issue: mentioned inside comment #7145 (comment) ``` + assert_service_name_equals '{"name":"service_call_rate","type":"GAUGE","help":"calls/sec, grouped by service","metrics":[]}' driver + local 'response={"name":"service_call_rate","type":"GAUGE","help":"calls/sec, grouped by service","metrics":[]}' + local expected=driver ++ echo '{"name":"service_call_rate","type":"GAUGE","help":"calls/sec, grouped by service","metrics":[]}' ++ jq -r 'if .metrics and .metrics[0] then .metrics[0].labels[] | select(.name=="service_name") | .value else empty end' + service_name= + [[ '' != \d\r\i\v\e\r ]] + echo '❌ ERROR: Obtained service_name: '\'''\'' are not same as expected: '\''driver'\''' + return 1 ❌ ERROR: Obtained service_name: '' are not same as expected: 'driver' + return 1 + sleep 10 ``` ## Description of the changes - Add empty check for result array ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: pipiland2612 <[email protected]>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test