Add retry configuration to storage exporter #7132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lokesh Kumar <[email protected]>
yurishkuro
changed the title
yurishkuro
reviewed
May 17, 2025
| - `max_interval`: 30s | ||
| - `max_elapsed_time`: 5m | ||
|
|
||
| #### Explanation of Retry Parameters |
Member
There was a problem hiding this comment.
why do we need this? Isn't it already documented in OTEL? I don't want to duplicate the docs, just refer to upstream docs.
yurishkuro
reviewed
May 17, 2025
| type Config struct { | ||
| TraceStorage string `mapstructure:"trace_storage" valid:"required"` | ||
| QueueConfig exporterhelper.QueueBatchConfig `mapstructure:"queue" valid:"optional"` | ||
| RetryConfig configretry.BackOffConfig `mapstructure:"retry_on_failure" valid:"optional"` |
Member
There was a problem hiding this comment.
I am not sure what valid:"optional" means in the context of having an actual struct by value.
yurishkuro
reviewed
May 17, 2025
| func createDefaultConfig() component.Config { | ||
| return &Config{} | ||
| return &Config{ | ||
| RetryConfig: configretry.BackOffConfig{ |
Member
There was a problem hiding this comment.
we don't want this enabled by default.
yurishkuro
reviewed
May 17, 2025
|
|
||
| defaultCfg := createDefaultConfig().(*Config) | ||
|
|
||
| if !cfg.RetryConfig.Enabled { |
Member
There was a problem hiding this comment.
we didn't have anything similar for other configs, why do we need it for this one?
Signed-off-by: Lokesh Kumar <[email protected]>
Contributor
Author
|
@yurishkuro addressed comments here 4d62811 |
yurishkuro
approved these changes
May 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7132 +/- ##
==========================================
- Coverage 96.20% 96.19% -0.02%
==========================================
Files 358 358
Lines 21596 21600 +4
==========================================
+ Hits 20777 20778 +1
- Misses 613 615 +2
- Partials 206 207 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
via the queue into
jaegertracing:main
with commit May 18, 2025
6f20915
58 of 59 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
storageexporterpackage.Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test