Add filterprocessor #7094
Merged
Add filterprocessor #7094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
added
the
changelog:new-feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7094 +/- ##
=======================================
Coverage 96.10% 96.10%
=======================================
Files 358 358
Lines 21584 21585 +1
=======================================
+ Hits 20744 20745 +1
Misses 633 633
Partials 207 207
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
added a commit
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - When previous PR #7094 was force-merged with binary size check failing (there's no way to override that check to succeed), the same check [failed](https://github.com/jaegertracing/jaeger/actions/runs/14816241094/job/41597074760) on `main` AND the steps to update the binary size cache did not run ## Description of the changes - Change the check for size to not run when on the main branch ## Testing - The check is expected to still fail for this PR and will have to be force-merged - But then the same check on main should succeed and update the cached value Signed-off-by: Yuri Shkuro <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - Resolves jaegertracing#6930 ## Description of the changes - Import `filterprocessor` as a counterpart to `attributeprocessor` - Increases the binary size by 2.18%, more than our "accidental" threshold, but acceptable ``` Previous binary size: 100223599 bytes New binary size: 102409625 bytes ❌ binary size increased by more than 2% (2.18%) ``` --------- Signed-off-by: Yuri Shkuro <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - When previous PR jaegertracing#7094 was force-merged with binary size check failing (there's no way to override that check to succeed), the same check [failed](https://github.com/jaegertracing/jaeger/actions/runs/14816241094/job/41597074760) on `main` AND the steps to update the binary size cache did not run ## Description of the changes - Change the check for size to not run when on the main branch ## Testing - The check is expected to still fail for this PR and will have to be force-merged - But then the same check on main should succeed and update the cached value Signed-off-by: Yuri Shkuro <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - Resolves jaegertracing#6930 ## Description of the changes - Import `filterprocessor` as a counterpart to `attributeprocessor` - Increases the binary size by 2.18%, more than our "accidental" threshold, but acceptable ``` Previous binary size: 100223599 bytes New binary size: 102409625 bytes ❌ binary size increased by more than 2% (2.18%) ``` --------- Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - When previous PR jaegertracing#7094 was force-merged with binary size check failing (there's no way to override that check to succeed), the same check [failed](https://github.com/jaegertracing/jaeger/actions/runs/14816241094/job/41597074760) on `main` AND the steps to update the binary size cache did not run ## Description of the changes - Change the check for size to not run when on the main branch ## Testing - The check is expected to still fail for this PR and will have to be force-merged - But then the same check on main should succeed and update the cached value Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
filterprocessoras a counterpart toattributeprocessor