Skip to content

Upgrade reverse-proxy example to jaeger-v2 #7076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Apr 26, 2025

Which problem is this PR solving?

@yurishkuro yurishkuro marked this pull request as ready for review April 26, 2025 15:34
@yurishkuro yurishkuro requested a review from a team as a code owner April 26, 2025 15:34
@yurishkuro yurishkuro requested a review from joe-elliott April 26, 2025 15:34
@dosubot dosubot bot added the v2 label Apr 26, 2025
Copy link

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (fe2ad2e) to head (493944f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7076      +/-   ##
==========================================
+ Coverage   96.03%   96.05%   +0.01%     
==========================================
  Files         355      355              
  Lines       20993    20995       +2     
==========================================
+ Hits        20161    20166       +5     
+ Misses        626      624       -2     
+ Partials      206      205       -1     
Flag Coverage Δ
badger_v1 9.96% <ø> (ø)
badger_v2 2.06% <ø> (ø)
cassandra-4.x-v1-manual 14.99% <ø> (ø)
cassandra-4.x-v2-auto 2.05% <ø> (ø)
cassandra-4.x-v2-manual 2.05% <ø> (ø)
cassandra-5.x-v1-manual 14.99% <ø> (ø)
cassandra-5.x-v2-auto 2.05% <ø> (ø)
cassandra-5.x-v2-manual 2.05% <ø> (ø)
elasticsearch-6.x-v1 19.93% <ø> (ø)
elasticsearch-7.x-v1 20.01% <ø> (ø)
elasticsearch-8.x-v1 20.18% <ø> (ø)
elasticsearch-8.x-v2 2.06% <ø> (ø)
grpc_v1 11.52% <ø> (ø)
grpc_v2 2.06% <ø> (ø)
kafka-3.x-v1 10.24% <ø> (ø)
kafka-3.x-v2 2.06% <ø> (ø)
memory_v2 2.06% <ø> (ø)
opensearch-1.x-v1 20.06% <ø> (ø)
opensearch-2.x-v1 20.06% <ø> (ø)
opensearch-2.x-v2 2.06% <ø> (ø)
query 2.06% <ø> (ø)
tailsampling-processor 0.56% <ø> (ø)
unittests 94.82% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro enabled auto-merge April 26, 2025 15:36
@yurishkuro yurishkuro added this pull request to the merge queue Apr 26, 2025
Merged via the queue into jaegertracing:main with commit 244cccd Apr 26, 2025
59 of 60 checks passed
@yurishkuro yurishkuro deleted the fix-7074 branch April 26, 2025 16:01
@troosan
Copy link

troosan commented Apr 26, 2025

@yurishkuro thanks, that seems to be working fine indeed.

amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
## Which problem is this PR solving?
- Resolves of jaegertracing#7074

Signed-off-by: Yuri Shkuro <[email protected]>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
## Which problem is this PR solving?
- Resolves of jaegertracing#7074

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong documentation for use of base_path
3 participants