Skip to content

[v2] Implement FindTraceIDs for ES/OS #7035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2025

Conversation

Manik2708
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Implement FindTraceIDs for ES/OS

How was this change tested?

  • Unit Tests

Checklist

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (5873d1f) to head (342e3de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7035      +/-   ##
==========================================
- Coverage   96.04%   96.02%   -0.02%     
==========================================
  Files         352      352              
  Lines       20821    20852      +31     
==========================================
+ Hits        19998    20024      +26     
- Misses        620      624       +4     
- Partials      203      204       +1     
Flag Coverage Δ
badger_v1 9.97% <ø> (ø)
badger_v2 2.07% <ø> (ø)
cassandra-4.x-v1-manual 15.00% <ø> (ø)
cassandra-4.x-v2-auto 2.06% <ø> (ø)
cassandra-4.x-v2-manual 2.06% <ø> (ø)
cassandra-5.x-v1-manual 15.00% <ø> (ø)
cassandra-5.x-v2-auto 2.06% <ø> (ø)
cassandra-5.x-v2-manual 2.06% <ø> (ø)
elasticsearch-6.x-v1 19.95% <ø> (ø)
elasticsearch-7.x-v1 20.03% <ø> (ø)
elasticsearch-8.x-v1 20.20% <ø> (ø)
elasticsearch-8.x-v2 2.07% <ø> (ø)
grpc_v1 11.52% <ø> (ø)
grpc_v2 9.14% <ø> (ø)
kafka-3.x-v1 10.25% <ø> (ø)
kafka-3.x-v2 2.07% <ø> (ø)
memory_v2 2.07% <ø> (ø)
opensearch-1.x-v1 20.08% <ø> (ø)
opensearch-2.x-v1 20.08% <ø> (ø)
opensearch-2.x-v2 2.07% <ø> (ø)
tailsampling-processor 0.56% <ø> (ø)
unittests 94.79% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Manik2708 Manik2708 requested a review from yurishkuro April 19, 2025 12:53
Signed-off-by: Manik2708 <[email protected]>
@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Apr 19, 2025
@yurishkuro yurishkuro added this pull request to the merge queue Apr 19, 2025
Merged via the queue into jaegertracing:main with commit 4f46ecd Apr 19, 2025
56 of 57 checks passed
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
## Which problem is this PR solving?
- Fixes a part of: jaegertracing#7034 

## Description of the changes
- Implement `FindTraceIDs` for ES/OS 

## How was this change tested?
- Unit Tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Manik2708 <[email protected]>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
## Which problem is this PR solving?
- Fixes a part of: jaegertracing#7034

## Description of the changes
- Implement `FindTraceIDs` for ES/OS

## How was this change tested?
- Unit Tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants