[v2] Implement WriteTraces for Memory backend
#7027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manik2708 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7027 +/- ##
==========================================
+ Coverage 96.01% 96.02% +0.01%
==========================================
Files 349 351 +2
Lines 20677 20806 +129
==========================================
+ Hits 19852 19980 +128
Misses 622 622
- Partials 203 204 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I recommend you create a separate sub-issue of the main ticket dedicated to specific storage backend, not link everything to a single umbrella ticket. |
yurishkuro
reviewed
Apr 14, 2025
Signed-off-by: Manik2708 <[email protected]>
yurishkuro
added
the
changelog:exprimental
yurishkuro
reviewed
Apr 15, 2025
yurishkuro
reviewed
Apr 16, 2025
yurishkuro
reviewed
Apr 16, 2025
yurishkuro
reviewed
Apr 16, 2025
Signed-off-by: Manik2708 <[email protected]>
yurishkuro
reviewed
Apr 16, 2025
yurishkuro
reviewed
Apr 16, 2025
yurishkuro
reviewed
Apr 16, 2025
yurishkuro
reviewed
Apr 16, 2025
yurishkuro
reviewed
Apr 16, 2025
internal/storage/v2/memory/memory.go
Outdated
| for _, span := range spanSlice.All() { | ||
| // Collect all the spans with same trace id within the same scope span sameTraceIDSpanSlice | ||
| if sameTraceIDSpanSlice, ok := sameTraceIDSpans[span.TraceID()]; ok { | ||
| span.CopyTo(sameTraceIDSpanSlice.AppendEmpty()) |
There was a problem hiding this comment.
is CopyTo doing a deep copy or shallow (just copying pointer to the underlying Proto object)?
yurishkuro
reviewed
Apr 16, 2025
yurishkuro
reviewed
Apr 16, 2025
yurishkuro
reviewed
Apr 16, 2025
yurishkuro
reviewed
Apr 16, 2025
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
yurishkuro
reviewed
Apr 18, 2025
Signed-off-by: Manik2708 <[email protected]>
Manik2708
commented
Apr 18, 2025
| defer t.Unlock() | ||
| if _, ok := t.operations[serviceName]; ok { | ||
| t.operations[serviceName][operation] = struct{}{} | ||
| return |
There was a problem hiding this comment.
Reduced the nesting here also
yurishkuro
approved these changes
Apr 18, 2025
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - Fixes a part of: jaegertracing#6458 ## Description of the changes - Implement `WriteTraces` for memory backend ## How was this change tested? - Unit And Snapshot Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Manik2708 <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - Fixes a part of: jaegertracing#6458 ## Description of the changes - Implement `WriteTraces` for memory backend ## How was this change tested? - Unit And Snapshot Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Manik2708 <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
WriteTracesfor memory backendHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test