Skip to content

[grpc][v2] Implement OTLP exporter API in gRPC v2 handler #7012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • Implement the Export (from OTEL's Exporter API) call in the gRPC v2 handler

How was this change tested?

  • Added unit tests

Checklist

Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
@mahadzaryab1 mahadzaryab1 added the changelog:exprimental Change to an experimental part of the code label Apr 11, 2025
@mahadzaryab1 mahadzaryab1 requested a review from yurishkuro April 11, 2025 00:30
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner April 11, 2025 00:30
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.01%. Comparing base (6c5d0f3) to head (54c5af9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7012   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         346      346           
  Lines       20604    20611    +7     
=======================================
+ Hits        19782    19789    +7     
  Misses        620      620           
  Partials      202      202           
Flag Coverage Δ
badger_v1 10.48% <ø> (ø)
badger_v2 2.17% <ø> (ø)
cassandra-4.x-v1-manual 15.77% <ø> (ø)
cassandra-4.x-v2-auto 2.16% <ø> (ø)
cassandra-4.x-v2-manual 2.16% <ø> (ø)
cassandra-5.x-v1-manual 15.77% <ø> (ø)
cassandra-5.x-v2-auto 2.16% <ø> (ø)
cassandra-5.x-v2-manual 2.16% <ø> (ø)
elasticsearch-6.x-v1 20.87% <ø> (ø)
elasticsearch-7.x-v1 20.95% <ø> (ø)
elasticsearch-8.x-v1 21.13% <ø> (ø)
elasticsearch-8.x-v2 2.17% <ø> (ø)
grpc_v1 11.56% <ø> (ø)
grpc_v2 8.43% <ø> (ø)
kafka-3.x-v1 10.77% <ø> (ø)
kafka-3.x-v2 2.17% <ø> (ø)
memory_v2 2.17% <ø> (ø)
opensearch-1.x-v1 21.00% <ø> (ø)
opensearch-2.x-v1 21.00% <ø> (ø)
opensearch-2.x-v2 2.17% <ø> (ø)
tailsampling-processor 0.59% <ø> (ø)
unittests 94.81% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added this pull request to the merge queue Apr 11, 2025
Merged via the queue into jaegertracing:main with commit f8cc3f8 Apr 11, 2025
59 checks passed
AnmolxSingh pushed a commit to AnmolxSingh/jaeger that referenced this pull request Apr 11, 2025
…ing#7012)

## Which problem is this PR solving?
- Towards jaegertracing#6979

## Description of the changes
- Implement the `Export` (from OTEL's Exporter API) call in the gRPC v2
handler

## How was this change tested?
- Added unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
…ing#7012)

## Which problem is this PR solving?
- Towards jaegertracing#6979

## Description of the changes
- Implement the `Export` (from OTEL's Exporter API) call in the gRPC v2
handler

## How was this change tested?
- Added unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
…ing#7012)

## Which problem is this PR solving?
- Towards jaegertracing#6979

## Description of the changes
- Implement the `Export` (from OTEL's Exporter API) call in the gRPC v2
handler

## How was this change tested?
- Added unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/otel changelog:exprimental Change to an experimental part of the code v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants