[ES][v2] Change the DB Tag value from string to any type
#6994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manik2708
commented
Apr 7, 2025
internal/storage/v2/elasticsearch/tracestore/from_dbmodel_test.go
Outdated
Show resolved
Hide resolved
yurishkuro
reviewed
Apr 7, 2025
yurishkuro
reviewed
Apr 7, 2025
yurishkuro
reviewed
Apr 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6994 +/- ##
==========================================
- Coverage 95.98% 95.98% -0.01%
==========================================
Files 346 346
Lines 20552 20587 +35
==========================================
+ Hits 19727 19760 +33
- Misses 622 624 +2
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
|
/Don't Merge Firstly let the #6998 get merged, there are some changes which will be required in this PR after analaysing the integration tests! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2025
## Which problem is this PR solving? - Discussed in #6994 ## Description of the changes - We shouldn't be storing values as string in ES rather they should be stored raw but due to some unkown reason they were being stored as string so now backward compatibility should be considered for the old data and new data should be stored as raw ## How was this change tested? - Unit and E2E Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Manik2708 <[email protected]>
|
@yurishkuro From the PR: #6998 we got to know from integration tests that when span is extracted from ES, number is extracted as |
Signed-off-by: Manik2708 <[email protected]>
yurishkuro
approved these changes
Apr 10, 2025
yurishkuro
added
the
changelog:exprimental
Merged
via the queue into
jaegertracing:main
with commit Apr 10, 2025
6c5d0f3
56 of 58 checks passed
AnmolxSingh
pushed a commit
to AnmolxSingh/jaeger
that referenced
this pull request
Apr 11, 2025
…racing#6994) ## Which problem is this PR solving? Fixes a part of: jaegertracing#6458 ## Description of the changes - As discussed in jaegertracing#6946 we need to change the value which was saved as string in v1 to a raw value in v2 ## How was this change tested? - Unit Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Manik2708 <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…racing#6998) ## Which problem is this PR solving? - Discussed in jaegertracing#6994 ## Description of the changes - We shouldn't be storing values as string in ES rather they should be stored raw but due to some unkown reason they were being stored as string so now backward compatibility should be considered for the old data and new data should be stored as raw ## How was this change tested? - Unit and E2E Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Manik2708 <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…racing#6994) ## Which problem is this PR solving? Fixes a part of: jaegertracing#6458 ## Description of the changes - As discussed in jaegertracing#6946 we need to change the value which was saved as string in v1 to a raw value in v2 ## How was this change tested? - Unit Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Manik2708 <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…racing#6998) ## Which problem is this PR solving? - Discussed in jaegertracing#6994 ## Description of the changes - We shouldn't be storing values as string in ES rather they should be stored raw but due to some unkown reason they were being stored as string so now backward compatibility should be considered for the old data and new data should be stored as raw ## How was this change tested? - Unit and E2E Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Manik2708 <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…racing#6994) ## Which problem is this PR solving? Fixes a part of: jaegertracing#6458 ## Description of the changes - As discussed in jaegertracing#6946 we need to change the value which was saved as string in v1 to a raw value in v2 ## How was this change tested? - Unit Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Manik2708 <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes a part of: #6458
Description of the changes
NestedTagsandFieldTagsdistinction atCoreSpanWriterlevel #6946 we need to change the value which was saved as string in v1 to a raw value in v2How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test