[grpc][v2] Implement GetServices in grpc v2 handler
#6980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
added
the
changelog:exprimental
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6980 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 345 346 +1
Lines 20377 20389 +12
=======================================
+ Hits 19556 19568 +12
Misses 618 618
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
reviewed
Apr 5, 2025
yurishkuro
approved these changes
Apr 5, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
changed the title
GetServices in grpc v2 serverGetServices in grpc v2 handler
auto-merge was automatically disabled
April 5, 2025 15:22
Pull Request is not mergeable
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…6980) ## Which problem is this PR solving? - Towards jaegertracing#6979 ## Description of the changes - Add a new file `handler.go` to house the gRPC handler that will be consumed by the remote-storage binary. This handler will just delegate to our storage backend. - Implement the `GetServices` call in the server ## How was this change tested? - Added unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…6980) ## Which problem is this PR solving? - Towards jaegertracing#6979 ## Description of the changes - Add a new file `handler.go` to house the gRPC handler that will be consumed by the remote-storage binary. This handler will just delegate to our storage backend. - Implement the `GetServices` call in the server ## How was this change tested? - Added unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
handler.goto house the gRPC handler that will be consumed by the remote-storage binary. This handler will just delegate to our storage backend.GetServicescall in the serverHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test