Minor fixes to release checklist generator #6976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: albertteoh <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6976 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 345 345
Lines 20377 20377
=======================================
Hits 19556 19556
Misses 618 618
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
albertteoh
commented
Apr 4, 2025
|
|
||
| if $dry_run; then | ||
| echo "${issue_body}" | ||
| else | ||
| gh issue create --title "Prepare Jaeger Release ${new_version}" --body "$issue_body" | ||
| gh issue create -R jaegertracing/jaeger --title "Prepare Jaeger Release ${new_version}" --body "$issue_body" |
There was a problem hiding this comment.
I was presented with the option of creating the issue on my fork or on jaegertracing. This should remove that additional friction.
| @@ -59,12 +59,15 @@ echo "Using new version: ${new_version}" | |||
| TMPFILE=$(mktemp "/tmp/DOC_RELEASE.XXXXXX") | |||
| wget -O "$TMPFILE" https://raw.githubusercontent.com/jaegertracing/documentation/main/RELEASE.md | |||
|
|
|||
| issue_body=$(python scripts/utils/formatter.py "${TMPFILE}" "${user_version_v1}" "${user_version_v2}") | |||
| # Ensure the UI Release checklist is up to date. | |||
| make init-submodules | |||
There was a problem hiding this comment.
I had a very old version of the jaeger-ui submodule, missing the BEGIN_CHECKLIST comment.
Moreover, this ensures we pick up any changes to the Jaeger UI release process.
| # Ensure the UI Release checklist is up to date. | ||
| make init-submodules | ||
|
|
||
| issue_body=$(python scripts/release/formatter.py "${TMPFILE}" "${user_version_v1}" "${user_version_v2}") |
There was a problem hiding this comment.
The formatter.py path had changed from utils to release.
yurishkuro
approved these changes
Apr 4, 2025
Thanks @yurishkuro, added here: #6977 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 5, 2025
## Which problem is this PR solving? - Fast follow to this comment: #6976 (review) ## Checklist - [x] I have signed all commits Signed-off-by: albertteoh <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Description of the changes - Discovered some small issues while running the `scripts/release/start.sh` script. ## How was this change tested? - Able to successfully create the checklist from a cold start with these fixes in place: jaegertracing#6975 ## Checklist - [x] I have signed all commits Signed-off-by: albertteoh <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - Fast follow to this comment: jaegertracing#6976 (review) ## Checklist - [x] I have signed all commits Signed-off-by: albertteoh <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Description of the changes - Discovered some small issues while running the `scripts/release/start.sh` script. ## How was this change tested? - Able to successfully create the checklist from a cold start with these fixes in place: jaegertracing#6975 ## Checklist - [x] I have signed all commits Signed-off-by: albertteoh <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - Fast follow to this comment: jaegertracing#6976 (review) ## Checklist - [x] I have signed all commits Signed-off-by: albertteoh <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
scripts/release/start.shscript.How was this change tested?
Checklist