Move model/json to internal/uimodel #6973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6973 +/- ##
==========================================
- Coverage 96.21% 96.20% -0.01%
==========================================
Files 345 345
Lines 20359 20359
==========================================
- Hits 19588 19586 -2
- Misses 581 583 +2
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
reviewed
Apr 3, 2025
| @@ -9,7 +9,7 @@ import ( | |||
| "strings" | |||
|
|
|||
| "github.com/jaegertracing/jaeger-idl/model/v1" | |||
| "github.com/jaegertracing/jaeger/model/json" | |||
| v1 "github.com/jaegertracing/jaeger/internal/uimodel/converter/v1" | |||
There was a problem hiding this comment.
keep the alias as json to minimize code changes
There was a problem hiding this comment.
Hi, I've fixed it. Thanks for noticing
pipiland2612
force-pushed
the
6869-move-model/json
branch
2 times, most recently
from
9972a87 to
da15dce
Compare
Signed-off-by: pipiland <[email protected]>
Signed-off-by: pipiland <[email protected]>
pipiland2612
force-pushed
the
6869-move-model/json
branch
from
da15dce to
46cf18a
Compare
Signed-off-by: pipiland <[email protected]>
Signed-off-by: pipiland <[email protected]>
yurishkuro
added
the
changelog:refactoring
pipiland2612
changed the title
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…ing#6973) ## Which problem is this PR solving? - Resolves jaegertracing#6869 ## Description of the changes - move `model/json` to `internal/uimodel/converter/v1` - remove unused `fixture.json` and `model` pakage - move `model/json/model.go` to `internal/uimodel/converter/v1` ## How was this change tested? - pass project test ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: pipiland <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…ing#6973) ## Which problem is this PR solving? - Resolves jaegertracing#6869 ## Description of the changes - move `model/json` to `internal/uimodel/converter/v1` - remove unused `fixture.json` and `model` pakage - move `model/json/model.go` to `internal/uimodel/converter/v1` ## How was this change tested? - pass project test ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: pipiland <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
model/jsontointernal/uimodel/converter/v1fixture.jsonandmodelpakagemodel/jsontointernal/uimodelinternal/converter/jsontointernal/uimodel/v1/converter/jsonHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test