Skip to content

[grpc][v2] Implement gRPC v2 factory #6968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 2, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Apr 2, 2025

Which problem is this PR solving?

Description of the changes

  • This PR implements the following factories for gRPC storage
    • io.Closer
    • tracestore.Factory
    • depstore.Factory

How was this change tested?

  • Added unit tests

Checklist

Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
@mahadzaryab1 mahadzaryab1 added the changelog:exprimental Change to an experimental part of the code label Apr 2, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 96.15385% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.24%. Comparing base (13cb216) to head (274def7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/storage/v2/grpc/factory.go 95.83% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6968      +/-   ##
==========================================
+ Coverage   96.21%   96.24%   +0.02%     
==========================================
  Files         343      345       +2     
  Lines       20281    20359      +78     
==========================================
+ Hits        19513    19594      +81     
+ Misses        579      577       -2     
+ Partials      189      188       -1     
Flag Coverage Δ
badger_v1 10.53% <ø> (ø)
badger_v2 2.18% <ø> (ø)
cassandra-4.x-v1-manual 15.84% <ø> (ø)
cassandra-4.x-v2-auto 2.17% <ø> (ø)
cassandra-4.x-v2-manual 2.17% <ø> (ø)
cassandra-5.x-v1-manual 15.84% <ø> (ø)
cassandra-5.x-v2-auto 2.17% <ø> (ø)
cassandra-5.x-v2-manual 2.17% <ø> (ø)
elasticsearch-6.x-v1 20.76% <ø> (ø)
elasticsearch-7.x-v1 20.84% <ø> (ø)
elasticsearch-8.x-v1 21.02% <ø> (ø)
elasticsearch-8.x-v2 2.18% <ø> (ø)
grpc_v1 11.61% <ø> (ø)
grpc_v2 8.47% <ø> (ø)
kafka-3.x-v1 10.82% <ø> (ø)
kafka-3.x-v2 2.18% <ø> (ø)
memory_v2 2.18% <ø> (ø)
opensearch-1.x-v1 20.89% <ø> (ø)
opensearch-2.x-v1 20.89% <ø> (ø)
opensearch-2.x-v2 2.18% <ø> (ø)
tailsampling-processor 0.59% <ø> (ø)
unittests 95.03% <96.15%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
@mahadzaryab1 mahadzaryab1 changed the title [WIP][grpc][v2] Implement gRPC v2 factory [grpc][v2] Implement gRPC v2 factory Apr 2, 2025
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review April 2, 2025 20:57
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner April 2, 2025 20:57
@mahadzaryab1 mahadzaryab1 requested a review from albertteoh April 2, 2025 20:57
@mahadzaryab1 mahadzaryab1 requested a review from yurishkuro April 2, 2025 20:57
Signed-off-by: Mahad Zaryab <[email protected]>
@mahadzaryab1 mahadzaryab1 enabled auto-merge April 2, 2025 21:17
@mahadzaryab1 mahadzaryab1 added this pull request to the merge queue Apr 2, 2025
Merged via the queue into jaegertracing:main with commit dddd44c Apr 2, 2025
56 checks passed
@mahadzaryab1 mahadzaryab1 deleted the grpc-v2-factory branch April 3, 2025 00:18
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?
- Towards jaegertracing#6965

## Description of the changes
- This PR implements the following factories for gRPC storage
  - `io.Closer`
  - `tracestore.Factory`
  - `depstore.Factory`
## How was this change tested?
- Added unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?
- Towards jaegertracing#6965

## Description of the changes
- This PR implements the following factories for gRPC storage
  - `io.Closer`
  - `tracestore.Factory`
  - `depstore.Factory`
## How was this change tested?
- Added unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage changelog:exprimental Change to an experimental part of the code v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants