Skip to content

Add e2e integration test for Query Service #6966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 7, 2025
Merged

Add e2e integration test for Query Service #6966

merged 10 commits into from
Apr 7, 2025

Conversation

pipiland2612
Copy link
Contributor

@pipiland2612 pipiland2612 commented Apr 2, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Add new e2e integration tests to exercise jaeger-query.yaml configuration
    • Add configure e2e pipeline

How was this change tested?

  • STORAGE=query SPAN_STORAGE_TYPE=memory make jaeger-v2-storage-integration-test command runs successfully locally

Checklist

@pipiland2612 pipiland2612 force-pushed the 6683-integration-test branch from c8c2945 to f30a9af Compare April 2, 2025 19:03
@pipiland2612 pipiland2612 force-pushed the 6683-integration-test branch from f30a9af to 21322d7 Compare April 2, 2025 19:03
@pipiland2612 pipiland2612 marked this pull request as ready for review April 2, 2025 19:04
@pipiland2612 pipiland2612 requested a review from a team as a code owner April 2, 2025 19:04
@pipiland2612 pipiland2612 requested a review from joe-elliott April 2, 2025 19:04
@dosubot dosubot bot added the area/storage label Apr 2, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (2fb42ef) to head (4d82abe).
Report is 29 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6966      +/-   ##
==========================================
- Coverage   96.19%   95.95%   -0.25%     
==========================================
  Files         344      346       +2     
  Lines       20253    20429     +176     
==========================================
+ Hits        19483    19603     +120     
- Misses        581      622      +41     
- Partials      189      204      +15
Flag Coverage Δ
badger_v1 10.53% <ø> (+0.32%) ⬆️
badger_v2 2.18% <ø> (+0.06%) ⬆️
cassandra-4.x-v1-manual 15.84% <ø> (+0.48%) ⬆️
cassandra-4.x-v2-auto 2.17% <ø> (+0.06%) ⬆️
cassandra-4.x-v2-manual 2.17% <ø> (+0.06%) ⬆️
cassandra-5.x-v1-manual 15.84% <ø> (+0.48%) ⬆️
cassandra-5.x-v2-auto 2.17% <ø> (+0.06%) ⬆️
cassandra-5.x-v2-manual 2.17% <ø> (+0.06%) ⬆️
elasticsearch-6.x-v1 20.76% <ø> (+0.63%) ⬆️
elasticsearch-7.x-v1 20.84% <ø> (+0.63%) ⬆️
elasticsearch-8.x-v1 21.02% <ø> (+0.64%) ⬆️
elasticsearch-8.x-v2 2.18% <ø> (+0.06%) ⬆️
grpc_v1 11.61% <ø> (+0.33%) ⬆️
grpc_v2 8.47% <ø> (+0.23%) ⬆️
kafka-3.x-v1 10.82% <ø> (+0.30%) ⬆️
kafka-3.x-v2 2.18% <ø> (+0.06%) ⬆️
memory_v2 2.18% <ø> (+0.06%) ⬆️
opensearch-1.x-v1 20.89% <ø> (+0.63%) ⬆️
opensearch-2.x-v1 20.89% <ø> (+0.63%) ⬆️
opensearch-2.x-v2 2.18% <ø> (+0.06%) ⬆️
tailsampling-processor 0.59% <ø> (+0.01%) ⬆️
unittests 94.75% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yurishkuro
yurishkuro reviewed Apr 2, 2025
View reviewed changes
@pipiland2612 pipiland2612 force-pushed the 6683-integration-test branch from 7e32015 to 38d4a77 Compare April 2, 2025 19:46
yurishkuro
yurishkuro reviewed Apr 2, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Apr 2, 2025
View reviewed changes
@pipiland2612 pipiland2612 changed the title Add e2e integration test for Query Service Add e2e integration test for Query Service [WIP] Apr 2, 2025
@pipiland2612 pipiland2612 changed the title Add e2e integration test for Query Service [WIP] [WIP] Add e2e integration test for Query Service Apr 2, 2025
@pipiland2612 pipiland2612 changed the title [WIP] Add e2e integration test for Query Service Add e2e integration test for Query Service Apr 3, 2025
@pipiland2612 pipiland2612 force-pushed the 6683-integration-test branch from 3cbdd34 to 73c7f9b Compare April 3, 2025 20:02
yurishkuro
yurishkuro reviewed Apr 3, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Apr 3, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Apr 3, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Apr 3, 2025
View reviewed changes
@pipiland2612
Copy link
Contributor Author

@yurishkuro Hi, the pull request is ready to be reviewed. Looking forwards to your response !

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Apr 6, 2025
yurishkuro
yurishkuro reviewed Apr 6, 2025
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pipiland2612 pipiland2612 force-pushed the 6683-integration-test branch from f037a5d to e59ec57 Compare April 7, 2025 06:09
@pipiland2612 pipiland2612 force-pushed the 6683-integration-test branch from e59ec57 to 4d82abe Compare April 7, 2025 06:24
@yurishkuro yurishkuro added this pull request to the merge queue Apr 7, 2025
Merged via the queue into jaegertracing:main with commit 04d2983 Apr 7, 2025
56 checks passed
@pipiland2612 pipiland2612 deleted the 6683-integration-test branch April 7, 2025 16:35
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@pipiland2612 @yurishkuro @amol-verma-allen
Add e2e integration test for Query Service (jaegertracing#6966)
2b47591 
## Which problem is this PR solving?
- part of jaegertracing#6683

## Description of the changes

- Add new e2e integration tests to exercise jaeger-query.yaml
configuration
   - Add configure e2e pipeline

## How was this change tested?
- `STORAGE=query SPAN_STORAGE_TYPE=memory make
jaeger-v2-storage-integration-test ` command runs successfully locally

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: pipiland <[email protected]>
Signed-off-by: pipiland <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@pipiland2612 @yurishkuro @amol-verma-allen
Add e2e integration test for Query Service (jaegertracing#6966)
52fc5d3 
## Which problem is this PR solving?
- part of jaegertracing#6683

## Description of the changes

- Add new e2e integration tests to exercise jaeger-query.yaml
configuration
   - Add configure e2e pipeline

## How was this change tested?
- `STORAGE=query SPAN_STORAGE_TYPE=memory make
jaeger-v2-storage-integration-test ` command runs successfully locally

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: pipiland <[email protected]>
Signed-off-by: pipiland <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
area/storage changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pipiland2612 @yurishkuro