Move pkg/adjuster to cmd/query/app/querysvc/internal/adjuster #6956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pipiland <[email protected]>
mahadzaryab1
previously approved these changes
Apr 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6956 +/- ##
=======================================
Coverage 96.19% 96.20%
=======================================
Files 344 343 -1
Lines 20253 20266 +13
=======================================
+ Hits 19483 19496 +13
Misses 581 581
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mahadzaryab1
added
the
changelog:refactoring
|
please see feedback on #6916 |
mahadzaryab1
dismissed
their stale review
waiting on getting Yuri's feedback addressed
|
@yurishkuro thanks for the comment. Indeed, the primary client of the package is cmd/query/app/querysvc/query_service.go. However adjuster.ZipkinSpanIDUniquifier is used in internal/storage/v1/memory/memory.go. Could you advise if this is actually needed in internal/storage/v1/memory/memory.go at all? I don't see it in use for other Trace Storage like elasticsearch. If it's not needed, then it's straightforward to move to |
Feel free to remove it from memory storage. |
Move to |
…rage Signed-off-by: pipiland <[email protected]>
Signed-off-by: pipiland <[email protected]>
pipiland2612
force-pushed
the
6869-move-pkg-adjuster
branch
from
5c8f189 to
628f3be
Compare
yurishkuro
requested changes
Apr 2, 2025
cmd/query/app/querysvc/adjusters.go
Outdated
| @@ -7,20 +7,20 @@ package querysvc | |||
| import ( | |||
| "time" | |||
|
|
|||
| "github.com/jaegertracing/jaeger/model/adjuster" | |||
| adjuster2 "github.com/jaegertracing/jaeger/cmd/query/app/querysvc/internal/adjuster" | |||
There was a problem hiding this comment.
renaming is unnecessary change
There was a problem hiding this comment.
Agree. I adjusted this in 76f5ec5.
pipiland2612
changed the title
Signed-off-by: pipiland <[email protected]>
4 tasks
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…tracing#6956) ## Which problem is this PR solving? - part of jaegertracing#6869 ## Description of the changes - moved `pkg/adjuster` to `cmd/query/app/querysvc/internal/adjuster` ## How was this change tested? - changes have passed all tests of the project ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: pipiland <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…tracing#6956) ## Which problem is this PR solving? - part of jaegertracing#6869 ## Description of the changes - moved `pkg/adjuster` to `cmd/query/app/querysvc/internal/adjuster` ## How was this change tested? - changes have passed all tests of the project ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: pipiland <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
pkg/adjustertocmd/query/app/querysvc/internal/adjusterHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test