Skip to content

Move model/converter to internal/converter #6917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/anonymizer/app/anonymizer/anonymizer.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
"go.uber.org/zap"

"github.com/jaegertracing/jaeger-idl/model/v1"
uiconv "github.com/jaegertracing/jaeger/model/converter/json"
uiconv "github.com/jaegertracing/jaeger/internal/converter/json"
uimodel "github.com/jaegertracing/jaeger/model/json"
)

Expand Down
2 changes: 1 addition & 1 deletion cmd/collector/app/handler/thrift_span_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
"github.com/jaegertracing/jaeger-idl/thrift-gen/zipkincore"
"github.com/jaegertracing/jaeger/cmd/collector/app/processor"
zipkinS "github.com/jaegertracing/jaeger/cmd/collector/app/sanitizer/zipkin"
jConv "github.com/jaegertracing/jaeger/model/converter/thrift/jaeger"
jConv "github.com/jaegertracing/jaeger/internal/converter/thrift/jaeger"
)

// SubmitBatchOptions are passed to Submit methods of the handlers.
Expand Down
2 changes: 1 addition & 1 deletion cmd/query/app/http_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ import (
"github.com/jaegertracing/jaeger-idl/model/v1"
"github.com/jaegertracing/jaeger/cmd/query/app/qualitymetrics"
"github.com/jaegertracing/jaeger/cmd/query/app/querysvc"
uiconv "github.com/jaegertracing/jaeger/internal/converter/json"
"github.com/jaegertracing/jaeger/internal/jtracer"
"github.com/jaegertracing/jaeger/internal/storage/metricstore/disabled"
"github.com/jaegertracing/jaeger/internal/storage/v1/api/metricstore"
"github.com/jaegertracing/jaeger/internal/storage/v1/api/spanstore"
uiconv "github.com/jaegertracing/jaeger/model/converter/json"
ui "github.com/jaegertracing/jaeger/model/json"
"github.com/jaegertracing/jaeger/proto-gen/api_v2/metrics"
)
Expand Down
2 changes: 1 addition & 1 deletion crossdock/services/agent.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"go.uber.org/zap"

"github.com/jaegertracing/jaeger-idl/proto-gen/api_v2"
p2json "github.com/jaegertracing/jaeger/model/converter/json"
p2json "github.com/jaegertracing/jaeger/internal/converter/json"
)

var errSamplingRateMissing = errors.New("sampling rate is missing")
Expand Down
2 changes: 1 addition & 1 deletion crossdock/services/agent_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
"go.uber.org/zap"

"github.com/jaegertracing/jaeger-idl/proto-gen/api_v2"
p2json "github.com/jaegertracing/jaeger/model/converter/json"
p2json "github.com/jaegertracing/jaeger/internal/converter/json"
)

var testResponse = &api_v2.SamplingStrategyResponse{
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (

"github.com/jaegertracing/jaeger-idl/proto-gen/api_v2"
api_v1 "github.com/jaegertracing/jaeger-idl/thrift-gen/sampling"
thriftconv "github.com/jaegertracing/jaeger/model/converter/thrift/jaeger"
thriftconv "github.com/jaegertracing/jaeger/internal/converter/thrift/jaeger"
)

func TestSamplingStrategyResponseToJSON_Error(t *testing.T) {
Expand Down
File renamed without changes.
4 changes: 2 additions & 2 deletions internal/sampling/http/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ import (
"github.com/gorilla/mux"

"github.com/jaegertracing/jaeger-idl/proto-gen/api_v2"
p2json "github.com/jaegertracing/jaeger/model/converter/json"
t2p "github.com/jaegertracing/jaeger/model/converter/thrift/jaeger"
p2json "github.com/jaegertracing/jaeger/internal/converter/json"
t2p "github.com/jaegertracing/jaeger/internal/converter/thrift/jaeger"
"github.com/jaegertracing/jaeger/pkg/metrics"
)

Expand Down
2 changes: 1 addition & 1 deletion internal/sampling/http/handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ import (
"github.com/stretchr/testify/require"

"github.com/jaegertracing/jaeger-idl/proto-gen/api_v2"
p2json "github.com/jaegertracing/jaeger/internal/converter/json"
"github.com/jaegertracing/jaeger/internal/metricstest"
tSampling092 "github.com/jaegertracing/jaeger/internal/sampling/http/thrift-0.9.2"
p2json "github.com/jaegertracing/jaeger/model/converter/json"
)

type testServer struct {
Expand Down
2 changes: 1 addition & 1 deletion pkg/gogocodec/codec_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func TestUseGogo(t *testing.T) {
}

func BenchmarkCodecUnmarshal25Spans(b *testing.B) {
const fileName = "../../model/converter/thrift/jaeger/fixtures/domain_01.json"
const fileName = "../../internal/converter/thrift/jaeger/fixtures/domain_01.json"
jsonFile, err := os.Open(fileName)
require.NoError(b, err, "Failed to open json fixture file %s", fileName)
var trace model.Trace
Expand Down
Loading