Move pkg/metrics to internal/metrics #6901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danish9039 <[email protected]>
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6901 +/- ##
==========================================
- Coverage 96.12% 96.11% -0.02%
==========================================
Files 340 340
Lines 19608 19608
==========================================
- Hits 18849 18846 -3
- Misses 574 576 +2
- Partials 185 186 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
approved these changes
Mar 22, 2025
yurishkuro
added
the
changelog:refactoring
yurishkuro
changed the title
Signed-off-by: danish9039 <[email protected]>
auto-merge was automatically disabled
March 23, 2025 14:22
Head branch was pushed to by a user without write access
yurishkuro
approved these changes
Mar 23, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
Conflicts. I should've merged this first since it's the biggest change. |
exactly , let me resolve these conflicts real quick |
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: hippie-danish <[email protected]>
Signed-off-by: hippie-danish <[email protected]>
@yurishkuro done ! |
yurishkuro
approved these changes
Mar 24, 2025
|
@danish9039 you left |
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - part of jaegertracing#6869 ## Description of the changes - moved `pkg/metrics` to `internal/metrics` ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: danish9039 <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: hippie-danish <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - part of jaegertracing#6869 ## Description of the changes - moved `pkg/metrics` to `internal/metrics` ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: danish9039 <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: hippie-danish <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
pkg/metricstointernal/metricsHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test