[ES] Move DB model out of v1/elasticsearch/internal/spanstore/internal
#6894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6894 +/- ##
==========================================
- Coverage 96.12% 96.11% -0.02%
==========================================
Files 339 339
Lines 19597 19597
==========================================
- Hits 18838 18835 -3
- Misses 574 576 +2
- Partials 185 186 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@yurishkuro @mahadzaryab1 What should be my next PR, implementing the writer for v2 or a directory structure with reader/writer implemented with |
|
Unit tests are passing locally, have to see what's going wrong in CI |
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
|
@yurishkuro @mahadzaryab1 Please review this PR as it is a blocker for implementing |
yurishkuro
reviewed
Mar 23, 2025
| @@ -17,6 +17,7 @@ import ( | |||
| "github.com/stretchr/testify/require" | |||
There was a problem hiding this comment.
Spanstore/internal/dbmodel is unnecessary nesting. Move it directly to spanstore/
Signed-off-by: Manik2708 <[email protected]>
Manik2708
commented
Mar 23, 2025
internal/storage/v1/elasticsearch/spanstore/dbmodel/from_domain_test.go
Outdated
Show resolved
Hide resolved
yurishkuro
added
the
changelog:refactoring
Signed-off-by: Manik2708 <[email protected]>
yurishkuro
approved these changes
Mar 23, 2025
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…al` (jaegertracing#6894) ## Which problem is this PR solving? Fixes a part of jaegertracing#6458 ## Description of the changes - Currently `dbmodel` can't be accessed by the `v2`, therefore it is moved out of `v1/elasticsearch/internal/spanstore/internal` ## How was this change tested? - Unit Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Manik2708 <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…al` (jaegertracing#6894) ## Which problem is this PR solving? Fixes a part of jaegertracing#6458 ## Description of the changes - Currently `dbmodel` can't be accessed by the `v2`, therefore it is moved out of `v1/elasticsearch/internal/spanstore/internal` ## How was this change tested? - Unit Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Manik2708 <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes a part of #6458
Description of the changes
dbmodelcan't be accessed by thev2, therefore it is moved out ofv1/elasticsearch/internal/spanstore/internalHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test