[all-in-one] Avoid multi-arch builds in merge queue (#6880) #6882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sAchin-680 <[email protected]>
yurishkuro
approved these changes
Mar 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6882 +/- ##
==========================================
- Coverage 96.14% 96.13% -0.02%
==========================================
Files 341 341
Lines 19641 19641
==========================================
- Hits 18883 18881 -2
- Misses 573 575 +2
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
added
the
changelog:ci
yurishkuro
changed the title
|
Thanks @yurishkuro for reviewing and approving the changes !! |
Merged
via the queue into
jaegertracing:main
with commit Mar 19, 2025
13111cb
56 of 58 checks passed
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…) (jaegertracing#6882) ## Which problem is this PR solving? - Resolves jaegertracing#6880: Optimizes the all-in-one CI workflow by preventing unnecessary multi-architecture builds in the merge queue, reducing build times. ## Description of the changes - Updated `.github/workflows/ci-docker-all-in-one.yml` to exclude multi-arch builds for merge queue events, similar to PR handling. - This prevents sequential multi-arch builds, significantly improving CI efficiency. ## How was this change tested? ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: sAchin-680 <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…) (jaegertracing#6882) ## Which problem is this PR solving? - Resolves jaegertracing#6880: Optimizes the all-in-one CI workflow by preventing unnecessary multi-architecture builds in the merge queue, reducing build times. ## Description of the changes - Updated `.github/workflows/ci-docker-all-in-one.yml` to exclude multi-arch builds for merge queue events, similar to PR handling. - This prevents sequential multi-arch builds, significantly improving CI efficiency. ## How was this change tested? ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: sAchin-680 <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
.github/workflows/ci-docker-all-in-one.ymlto exclude multi-arch builds for merge queue events, similar to PR handling.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test