Cleanup legacy models #6875
Merged
Cleanup legacy models #6875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6875 +/- ##
==========================================
- Coverage 96.21% 96.18% -0.04%
==========================================
Files 344 344
Lines 19976 19976
==========================================
- Hits 19219 19213 -6
- Misses 573 577 +4
- Partials 184 186 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mahadzaryab1
approved these changes
Mar 19, 2025
sAchin-680
pushed a commit
to sAchin-680/jaeger
that referenced
this pull request
Mar 19, 2025
## Which problem is this PR solving? - Follow-up to jaegertracing#6494 ## Description of the changes - Remove model files that only contained aliases to jaeger-idl types - model/*go - proto-gen/api_v2/*go - thrift-gen/** ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: sAchin-680 <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - Follow-up to jaegertracing#6494 ## Description of the changes - Remove model files that only contained aliases to jaeger-idl types - model/*go - proto-gen/api_v2/*go - thrift-gen/** ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - Follow-up to jaegertracing#6494 ## Description of the changes - Remove model files that only contained aliases to jaeger-idl types - model/*go - proto-gen/api_v2/*go - thrift-gen/** ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?