[grpc][v2] Implement FindTraceIDs Call in gRPC reader for remote storage api v2
#6858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6858 +/- ##
==========================================
+ Coverage 96.03% 96.13% +0.09%
==========================================
Files 367 341 -26
Lines 20831 19738 -1093
==========================================
- Hits 20005 18975 -1030
+ Misses 630 577 -53
+ Partials 196 186 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
reviewed
Mar 16, 2025
yurishkuro
reviewed
Mar 16, 2025
yurishkuro
approved these changes
Mar 16, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Mar 17, 2025
internal/jptrace/attributes.go
Outdated
| @@ -17,20 +14,3 @@ const ( | |||
| // e.g. proto, thrift, json. | |||
| FormatAttribute = "@jaeger@format" | |||
| ) | |||
|
|
|||
| func PcommonMapToPlainMap(attributes pcommon.Map) map[string]string { | |||
There was a problem hiding this comment.
I would've kept it here. Creating too many top packages at internal just creates clutter, and in this case it's a new package for just a couple of functions.
There was a problem hiding this comment.
@yurishkuro I had to do this because of circular dependencies. proto-gen uses jptrace.TracesData and this package needs to use proto-gen for converting to the key-value list. Let me know if you prefer a different approach. We could create a top-level jotel and create sub-packages jptrace and jpcommon in there. Or alternatively move the TracesData out of jptrace.
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Mar 19, 2025
internal/jpcommon/map.go
Outdated
|
|
||
| func PcommonMapToPlainMap(attributes pcommon.Map) map[string]string { | ||
| mapAttributes := make(map[string]string) | ||
| attributes.Range(func(k string, v pcommon.Value) bool { |
There was a problem hiding this comment.
nit: I recommend using the new iterator methods, I think it will be attributes.All()
There was a problem hiding this comment.
unless they still haven't merged those, I thought they did in the last release
yurishkuro
reviewed
Mar 19, 2025
yurishkuro
reviewed
Mar 19, 2025
yurishkuro
reviewed
Mar 19, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Mar 20, 2025
mahadzaryab1
added
changelog:exprimental
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…orage api v2 (jaegertracing#6858) <!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - Towards jaegertracing#6789 ## Description of the changes - This PR implements the GetOperations call in the gRPC v2 API client - In the process, we also had to add a helper to convert a `pcommon.Map` to the proto representation `[]*KeyValue`. ## How was this change tested? - Added unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…orage api v2 (jaegertracing#6858) <!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - Towards jaegertracing#6789 ## Description of the changes - This PR implements the GetOperations call in the gRPC v2 API client - In the process, we also had to add a helper to convert a `pcommon.Map` to the proto representation `[]*KeyValue`. ## How was this change tested? - Added unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
pcommon.Mapto the proto representation[]*KeyValue.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test