[fix] Allow es-index-cleaner to delete indices based on current time #6790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SatyamAgrawal <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
The pull request updates the es-index-cleaner to delete indices based on the current time, resolving issue #6236. The change replaces the previous logic that calculated the deletion date based on tomorrow's midnight with a calculation based on the current time. This seems like a good change, but I have a question about it.
Summary of Findings
- Timezone Considerations: The code uses
time.Now().UTC()to determine the current time. While this ensures consistency, it's important to verify that the Elasticsearch indices are also created using UTC time. If the indices are created using a different timezone, the deletion logic might not work as expected.
Merge Readiness
The code change appears straightforward and addresses the intended issue. However, it's crucial to ensure that the Elasticsearch indices are created using UTC time to avoid any unexpected behavior. I am unable to approve this pull request, and recommend that others review and approve this code before merging.
yurishkuro
reviewed
Mar 2, 2025
…breaking change Signed-off-by: SatyamAgrawal <[email protected]>
…xDeletion Signed-off-by: SatyamAgrawal <[email protected]>
Asatyam
force-pushed
the
fix_index_cleaner_date
branch
from
2b6b2bd to
585325a
Compare
|
@yurishkuro PTAL |
yurishkuro
changed the title
|
Please include evidence of testing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6790 +/- ##
==========================================
- Coverage 96.06% 96.04% -0.03%
==========================================
Files 364 365 +1
Lines 20712 20720 +8
==========================================
+ Hits 19897 19900 +3
- Misses 622 626 +4
- Partials 193 194 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… function Signed-off-by: SatyamAgrawal <[email protected]>
Signed-off-by: SatyamAgrawal <[email protected]>
Asatyam
force-pushed
the
fix_index_cleaner_date
branch
from
f52b9c4 to
5a9f3fe
Compare
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
reviewed
Mar 9, 2025
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
approved these changes
Mar 9, 2025
4 tasks
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…aegertracing#6790) ## Which problem is this PR solving? - Resolves jaegertracing#6236 ## Description of the changes - Changes the es-index-cleaner to remove indices older than 24 hours from the time it runs, so deletions happen hourly instead of just at midnight. ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: SatyamAgrawal <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…aegertracing#6790) ## Which problem is this PR solving? - Resolves jaegertracing#6236 ## Description of the changes - Changes the es-index-cleaner to remove indices older than 24 hours from the time it runs, so deletions happen hourly instead of just at midnight. ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: SatyamAgrawal <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test