Skip to content

Add example of ES/OS server_urls to configs #6601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jan 23, 2025

Which problem is this PR solving?

Description of the changes

  • Add server address

How was this change tested?

  • CI

@yurishkuro yurishkuro requested a review from a team as a code owner January 23, 2025 18:36
@yurishkuro yurishkuro requested a review from albertteoh January 23, 2025 18:36
@dosubot dosubot bot added the area/storage label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (f0b66c7) to head (a9879a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6601      +/-   ##
==========================================
- Coverage   96.21%   96.19%   -0.03%     
==========================================
  Files         377      377              
  Lines       21421    21421              
==========================================
- Hits        20611    20606       -5     
- Misses        616      620       +4     
- Partials      194      195       +1     
Flag Coverage Δ
badger_v1 10.63% <ø> (ø)
badger_v2 2.78% <ø> (ø)
cassandra-4.x-v1-manual 16.64% <ø> (ø)
cassandra-4.x-v2-auto 2.72% <ø> (ø)
cassandra-4.x-v2-manual 2.72% <ø> (ø)
cassandra-5.x-v1-manual 16.64% <ø> (ø)
cassandra-5.x-v2-auto 2.72% <ø> (ø)
cassandra-5.x-v2-manual 2.72% <ø> (ø)
elasticsearch-6.x-v1 20.44% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 20.50% <ø> (ø)
elasticsearch-8.x-v1 20.67% <ø> (ø)
elasticsearch-8.x-v2 2.89% <ø> (+0.11%) ⬆️
grpc_v1 12.20% <ø> (ø)
grpc_v2 9.05% <ø> (ø)
kafka-3.x-v1 10.36% <ø> (ø)
kafka-3.x-v2 2.78% <ø> (ø)
memory_v2 2.78% <ø> (+<0.01%) ⬆️
opensearch-1.x-v1 20.55% <ø> (-0.01%) ⬇️
opensearch-2.x-v1 20.55% <ø> (ø)
opensearch-2.x-v2 2.78% <ø> (+<0.01%) ⬆️
tailsampling-processor 0.51% <ø> (ø)
unittests 95.05% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro enabled auto-merge (squash) January 23, 2025 18:50
Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to make it easier for users.

@yurishkuro yurishkuro merged commit 07e4f57 into jaegertracing:main Jan 23, 2025
56 checks passed
@yurishkuro yurishkuro deleted the es-server-example branch January 23, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants