Skip to content

Separate model parts into more independent pieces #6581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jan 21, 2025

Which problem is this PR solving?

Description of the changes

  • Separate model files into more independent pieces that are easier to move to jaeger-idl

How was this change tested?

  • CI

// ToOTELSpanID converts the SpanID to OTEL's representation of a span identitfier.
// This was taken from
// https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/internal/coreinternal/idutils/big_endian_converter.go.
func (s SpanID) ToOTELSpanID() pcommon.SpanID {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: this needs to change to a standalone function without receiver: ToOTELSpanID(SpanID).

@yurishkuro yurishkuro enabled auto-merge (squash) January 21, 2025 15:29
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (976a36e) to head (edaf549).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6581      +/-   ##
==========================================
- Coverage   96.24%   96.21%   -0.03%     
==========================================
  Files         373      375       +2     
  Lines       21389    21389              
==========================================
- Hits        20585    20580       -5     
- Misses        612      616       +4     
- Partials      192      193       +1     
Flag Coverage Δ
badger_v1 10.65% <31.25%> (ø)
badger_v2 2.78% <37.50%> (ø)
cassandra-4.x-v1-manual 16.61% <43.75%> (ø)
cassandra-4.x-v2-auto 2.71% <37.50%> (ø)
cassandra-4.x-v2-manual 2.71% <37.50%> (ø)
cassandra-5.x-v1-manual 16.61% <43.75%> (ø)
cassandra-5.x-v2-auto 2.71% <37.50%> (ø)
cassandra-5.x-v2-manual 2.71% <37.50%> (ø)
elasticsearch-6.x-v1 20.39% <31.25%> (ø)
elasticsearch-7.x-v1 20.47% <31.25%> (+<0.01%) ⬆️
elasticsearch-8.x-v1 20.62% <31.25%> (-0.01%) ⬇️
elasticsearch-8.x-v2 2.78% <37.50%> (ø)
grpc_v1 12.18% <31.25%> (ø)
grpc_v2 9.03% <37.50%> (ø)
kafka-3.x-v1 10.34% <31.25%> (ø)
kafka-3.x-v2 2.78% <37.50%> (+<0.01%) ⬆️
memory_v2 2.77% <37.50%> (-0.01%) ⬇️
opensearch-1.x-v1 20.52% <31.25%> (+<0.01%) ⬆️
opensearch-2.x-v1 20.51% <31.25%> (-0.01%) ⬇️
opensearch-2.x-v2 2.77% <37.50%> (ø)
tailsampling-processor 0.51% <0.00%> (ø)
unittests 95.07% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro disabled auto-merge January 21, 2025 16:05
@yurishkuro yurishkuro merged commit 156a59d into jaegertracing:main Jan 21, 2025
56 checks passed
@yurishkuro yurishkuro deleted the cleaner-model branch January 21, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants