[refactor] Move sampling strategy providers to internal/sampling/samplingstrategy #6561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingstrategy Signed-off-by: Aryan Goyal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6561 +/- ##
===========================================
+ Coverage 50.24% 96.21% +45.97%
===========================================
Files 189 373 +184
Lines 11418 21400 +9982
===========================================
+ Hits 5737 20591 +14854
+ Misses 5226 616 -4610
+ Partials 455 193 -262
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
approved these changes
Jan 17, 2025
|
Thanks! |
|
Glad it could be helpful. Thanks for your time :) |
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 21, 2025
…lingstrategy (jaegertracing#6561) ## Which problem is this PR solving? - Resolves jaegertracing#6411 ## Description of the changes - Move sampling strategy providers from plugin/sampling/strategyprovider to internal/sampling/samplingstrategy ## How was this change tested? - Covered by existing ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Aryan Goyal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test